Adding bridge preset to highways not working

[anonymous]

Steps to reproduce:

1. Select a highway (eg. residential)
2. Search for bridge in presets
3. Apply bridge preset to the selected way
4. Nothing happens

[anonymous]

Although it's working if you add the bridge preset to an untagged way.

[GerdP]

With an untagged way the presets defaults to bridge=yes while with a tagged way you have to select what kind of bridge it is.
No idea if that is intended.

[anonymous]

Replying to GerdP:

No idea if that is intended.

Yeah, maybe intended but it's confusing.

[anonymous]

Replying to GerdP:

[...] with a tagged way you have to select what kind of bridge it is.

I see two possible solutions:

1. solution: Gray out the apply button until something is changed in the preset editor (or whatever it called)
2. solution: Use the same defaults (bridge=yes and layer=1) as with untagged ways or at least bridge=yes.

[GerdP]

I've now learned that the behaviour depends on a preference setting:
taggingpreset.fill-default-for-tagged-primitives
This is false by default. In Expertmode you can change it to true to get what you want.

[Klumbumbus]

The current behavior (ignoring defaults) is intended as users maybe do not expect that opening a preset from the Tags/Membership panel, changing nothing themself and closing with the apply preset button changes the object by adding tags. I can't find the ticket where Dirk explained that to me when I was confused about this ;)

[anonymous]

Replying to GerdP:

I've now learned that the behaviour depends on a preference setting:
taggingpreset.fill-default-for-tagged-primitives
This is false by default. In Expertmode you can change it to true to get what you want.

Thanks, it's working. But I don't want to be selfish. It would be great if all JOSM users would know about this flag (or fixed the issue :)

Replying to Klumbumbus:

The current behavior (ignoring defaults) is intended as users maybe do not expect that opening a preset from the Tags/Membership panel, changing nothing themself and closing with the apply preset button changes the object by adding tags. I can't find the ticket where Dirk explained that to me when I was confused about this ;)

Oh okay, this way it makes sense. Please, not forget that the presets can bring forth by searching (default shortcut is F3). This way it's not acceptable, that apply button does nothing. Also, I think by searching most people would like to add new tags, not modifying them.

The scenario you described above can be easily solved by:

1. Greying out the apply button until something is changed in the preset editor AND/OR
2. Checking where that preset editor activity called from. If from Tags/Membership panel -> disable defaults, else no change (enable).

[skyper]

Replying to Klumbumbus:

The current behavior (ignoring defaults) is intended as users maybe do not expect that opening a preset from the Tags/Membership panel, changing nothing themself and closing with the apply preset button changes the object by adding tags. I can't find the ticket where Dirk explained that to me when I was confused about this ;)

#12733

[gaben]

Replying to skyper:

#12733

Thanks! The anonymous reporter was me :) At the time I haven't registered yet.

This option should have a checkbox somewhere in the settings.