Opened 4 years ago
Last modified 4 years ago
#20284 new task
Move Mapillary Main to proper namespace
Reported by: | skyper | Owned by: | stoecker |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Trac | Version: | |
Keywords: | Mapillary | Cc: | taylor.smock |
Description
Is it possible to move wiki:/Dialog/MapillaryMain and its translations to proper namespace under wiki:/Help/Plugin/Mapillary, please. Thanks.
Sorry I have no user rights to do it myself.
Attachments (0)
Change History (7)
comment:1 by , 4 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
follow-up: 3 comment:2 by , 4 years ago
comment:3 by , 4 years ago
Ok, then, I think all three pages should be under wiki:/Help/Dialog and we need a new main wiki page wiki:/Help/Plugin/Mapillary for the plugin. It is needed for the macro for the index of documented plugins on the JOSM wiki at the bottom of wiki:/Plugins
comment:4 by , 4 years ago
Owner: | changed from | to
---|---|
Status: | assigned → new |
How to handle plugins pages? It seems most are currently under wiki/Help/Plugin/pluginname/.... On a quick look I see only one plugin related page under wiki/Help/Dialog/... (measurement)
comment:5 by , 4 years ago
The Help/Plugin/UtilsPlugin2 has its actions under wiki:/Help/Action. As it should be avoided to have name collisions and it works much better for the internal help system, I tend to have them all in "core" namespace instead of subpages of plugin pages. A page for each plugin under wiki:/Help/Plugin with links to its actions and dialogs should work as main page for the plugin.
comment:6 by , 4 years ago
It doesn't look like most plugins document the dialog windows or actions. (Specifically, Measurement and UtilsPlugin2 do).
Of the ones that do, it looks like they use whatever the defaults are.
Relevant default code:
comment:7 by , 4 years ago
From the wiki / JOSM core perspective, where should I put the dialog/action help pages? I'd like to move them to the appropriate locations, and then implement plugin support if necessary.
It would make sense to move wiki:/Dialog/MapillaryMain to the proper namespace, but please keep in mind that all dialog help windows go to wiki:/Help/Dialog/<classname>, absent extra code. The Mapillary filter dialog help pages (wiki:/Help/Plugin/Mapillary/Dialog/MapillaryFilter and wiki:/Help/Plugin/Mapillary/Dialog/MapillaryExpertFilter ) required me to override
helpTopic
in both dialog classes (see 16ca82c274c7188ff33be2c600d89ef13a491070 for the specific changes).So, it should (a) either be moved to the Plugin subhelp or (b) moved to the actual expected location ( wiki:/Help/Dialog/MapillaryMain ).