[RFC] [Patch] Replace ParentRelationLoadingTask by DownloadReferrersTask

[GerdP]

We have two very different classes which can download the parents of a relation:

• DownloadReferrersTask (used in Dialog for Download parent ways/relations... action and also in the Download object... action)
• ParentRelationLoadingTask(only used in relation editor for the Reloadbutton in the parents tab, found no plugin that uses it

For the first one we have a unit test, and it is frequently used. The second one is probably rarely used.
The patch implements the changes to replace the class and removes ParentRelationLoadingTask.

[GerdP]

Is it OK to simply remove a class that was in use since r1856? Or should it first be deprecated?

[stoecker]

Did you check plugins? If not used there, drop it :-)

[GerdP]

I searched the plugin sources and the *.jar files in dist directory and found no plugin using it. Is there another good way to verify?

[stoecker]

Replying to GerdP:

Is there another good way to verify?

Check in and wait for cries :-)

[GerdP]

In 17206/josm:

fix #19939 Replace ParentRelationLoadingTask by DownloadReferrersTask

• remove class ParentRelationLoadingTask
• adapt code to use DownloadReferrersTask instead

[Don-vip]

Milestone renamed