Opened 4 years ago
Closed 4 years ago
#19582 closed defect (fixed)
Stays silent if download is incomplete cause of timeouts
| Reported by: | skyper | Owned by: | GerdP |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugin reverter | Version: | |
| Keywords: | template_report incomplete download silent timeout | Cc: |
Description
What steps will reproduce the problem?
- Revert one way and all deleted objects to new layer. I used way and CS 83164338
- Get one conflict
- Try to select the object in mapview.
- Select object with conflict through conflict list panel
What is the expected result?
- I should be able to select the way in mapview
- No artifacts going to screen {0,0}
What happens instead?
- No way to select the way in mapview
- Artifacts once selected through conflict list panel
Please provide any additional information below. Attach a screenshot if possible.
Did not see this kind of artifact for a while now but here it is (again?). Remembered me about all the trouble changing to ODbL.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2020-07-25 14:35:24 +0200 (Sat, 25 Jul 2020) Revision:16808 Build-Date:2020-07-26 01:30:54 URL:https://josm.openstreetmap.de/svn/trunk Dataset consistency test: No problems found Plugins: + reverter (35499) Last errors/warnings: - W: Conflicts detected - <html>There was 1 conflict detected.</html>
Attachments (1)
Change History (14)
comment:1 by , 4 years ago
comment:2 by , 4 years ago
| Component: | Core → Plugin reverter |
|---|---|
| Keywords: | download silent timeout added; conflict select way child node removed |
| Owner: | changed from to |
| Summary: | Unable to select and artifacts to screen {0,0} once selected with a way with remaining conflict and incomplete or deleted child nodes → Stays silent if download is incomplete cause of timeouts |
comment:3 by , 4 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 4 years ago
I am not sure how to handle incomplete reverts. They may be caused by timeouts as well as the user pressing "Cancel".
The plugin doesn't only generate commands, it also adds downloaded objects to the data layer. It is rather easy to show a notification or a popup but it is much more difficult to work out what to do with the data that was already used to update the layer, esp. when multiple changesets are reverted.
I think it would be better to always create a new layer and maybe automatically merge it with the current edit layer if user
requests that.
comment:5 by , 4 years ago
+1
There is already the option for a new layer which could be reused.
If merge layers works properly, we could rely on it and have reverter only handle the download of objects.
follow-up: 8 comment:6 by , 4 years ago
I didn't mean to remove the creation of commands. I like to be able to use undo/redo to see what changed.
comment:8 by , 4 years ago
Replying to GerdP:
I didn't mean to remove the creation of commands. I like to be able to use undo/redo to see what changed.
I see, understandable and useful. In fact, undo of merge would be useful. Merge layers seems more complicated than merge selection. New ticket?
comment:9 by , 4 years ago
comment:12 by , 4 years ago
I'v e postponed the complex handling of incomplete reverts. Let's see if this helps or not.
comment:13 by , 4 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Damn, forgot to take the screenshot, and now, I cannot reproduce it. Could it be that the reverter plugin did not download all data cause of communication problems (timeouts)? I know "download parent" does silently fail a lot.