History browser: add "position/index of member" column

[simon04]

Suggested in ticket:19161#comment:13

Related: #15660 for an index column in the relation editor

[simon04]

What do you think of the drafted solution?

[GerdP]

I think it's easier to understand. Before looking at #19161 I did not even notice that there are different shades of green and red with different meaning in the history dialogs.

[skyper]

Much better +1

Note, I was stumbling as the screenshot on the right does not display all members of version "A". Are background colors only used on version "A" or does the example not show a case with colors on both versions?

[simon04]

Replying to skyper:

Note, I was stumbling as the screenshot on the right does not display all members of version "A". Are background colors only used on version "A" or does the example not show a case with colors on both versions?

The currend tested r16239 has the same behaviour as illustrated in the screenshot.

[skyper]

Replying to simon04:

Replying to skyper:

Note, I was stumbling as the screenshot on the right does not display all members of version "A". Are background colors only used on version "A" or does the example not show a case with colors on both versions?

The current tested r16239 has the same behaviour as illustrated in the screenshot.

• On the left side version "A" has 34 members, on the right side version "A" has only 27 members.
• With r16459 I have background colors on both sides and the example misses new members as show case which I expect to still have a green background.

[Klumbumbus]

Replying to skyper:

• On the left side version "A" has 34 members, on the right side version "A" has only 27 members.

Left compares version 9 with 10 and right 10 with "10 local edited".

[skyper]

Replying to Klumbumbus:

Replying to skyper:

• On the left side version "A" has 34 members, on the right side version "A" has only 27 members.

Left compares version 9 with 10 and right 10 with "10 local edited".

Ok, that's why I stumbled. The screenshots are not comparable.

[Klumbumbus]

Replying to skyper:

The screenshots are not comparable.

Yes, they are not "before-after", but both "after", just different examples.

[simon04]

In 16490/josm:

fix #19255 - History browser: add "index of node/member" column

[simon04]

In 16497/josm:

see #19255 - Java 8: use Stream

[skyper]

This influenced the background color highlighting which is now more confusing than before and broken. In fact, it turned #12548 and #13706 into defects.

[GerdP]

@skyper: Can you give an example?

[GerdP]

I see no changes in the code which would change the colouring, but #19253 looks like a good candidate.

[simon04]

In 16526/josm:

see #19255 - Java 8: use Stream

[skyper]

small example of problem

[skyper]

The problem is that the coloring is bounded to the rows and not the id, see my comment on #13706 (comment 4).