Modify

Opened 5 years ago

Last modified 4 years ago

#19194 new enhancement

[PATCH] Account for virtual plugins when offering to download and install missing plugins

Reported by: taylor.smock Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description

When updating Mapillary, javafx is not automatically installed. JOSM catches this on startup, but doesn't actually install javafx (since its a virtual plugin).

What this patch does:
1) Detects if a plugin can be installed on this platform
2) Detects if the plugin provides the "required" plugin
3) Detects if there are multiple candidates, and removes the possible duplicates (for safety (tm))
4) Performs the rest of the missing-plugin steps

What this patch does not do:

  • Detect that a plugin was uninstalled previously (since the plugin isn't downloaded, it isn't added to the plugin list, which means that it is not loaded)

Attachments (2)

19194.patch (1.5 KB ) - added by taylor.smock 5 years ago.
Install virtual plugins, when they are missing
19194.1.patch (1.4 KB ) - added by taylor.smock 5 years ago.
Remove duplicates had a slight bug. remove if (required plugins don't contain the plugin name or provides) OR if the plugin is not for the current platform (might be redundant). Instead of remove if (required plugins don't contain the plugin name or provides) and is for the current platform.

Download all attachments as: .zip

Change History (3)

by taylor.smock, 5 years ago

Attachment: 19194.patch added

Install virtual plugins, when they are missing

by taylor.smock, 5 years ago

Attachment: 19194.1.patch added

Remove duplicates had a slight bug. remove if (required plugins don't contain the plugin name or provides) OR if the plugin is not for the current platform (might be redundant). Instead of remove if (required plugins don't contain the plugin name or provides) and is for the current platform.

comment:1 by taylor.smock, 4 years ago

#KeepAlive (is this desired?)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to taylor.smock.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.