some unclosed ways are not found

[GerdP]

What steps will reproduce the problem?

1. Load attached file and run validator

What is the expected result?

• Warning "amenity type school" in group "Unclosed ways" similar to "landuse type residential (1)" for the leftmost way.
• Warning "natural type wood" in group "Unclosed ways" for the rightmost upper way.

What happens instead?

• Area style way is not closed (1) for the leftmost way (but only if the style renders it as area)
• no warning for the rightmost way

Please provide any additional information below. Attach a screenshot if possible.

This is a follow up from #19136

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-06 02:17:07 +0200 (Mon, 06 Apr 2020)
Build-Date:2020-04-06 00:18:43
Revision:16239
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16239 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1903 (18362)
Memory Usage: 877 MB / 1820 MB (496 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20200424_113048.jfr]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35414)
+ PolygonCutOut (v0.7)
+ apache-commons (35362)
+ buildings_tools (35405)
+ continuosDownload (91)
+ ejml (35313)
+ geotools (35169)
+ jaxb (35092)
+ jts (35122)
+ merge-overlap (35248)
+ o5m (35248)
+ opendata (35405)
+ pbf (35248)
+ poly (35248)
+ reverter (35409)
+ undelete (35405)
+ utilsplugin2 (35405)

Validator rules:
+ c:\josm\core\resources\data\validator\geometry.mapcss

[GerdP]

sample file

[GerdP]

In 16377/josm:

fix #19145: some unclosed ways are not found

• fix typo amenties -> amenity
• only ignore multipolygon members when checking unclosed boundary=* ways, others would be old style multipolygons

[Klumbumbus]

In 16378/josm:

see #19145 - Don't warn about unclosed amenity=bench|bicycle_parking

[GerdP]

I think I should add a test for place=*. Some are rendered as area, some are not. We could also replace the tests by mapcss rules but the java code hilites the open ends. So maybe the rule

/* #15648 */
way[place=island]!:closed {
  throwError: tr("Way with {0} not closed.", "{0.tag}");
}

should be replaced by the java code? It throws an error, the java code a warning. I think place=island is no special case.

[Klumbumbus]

A little background history: I disabled place fill color some years ago for reasons given in #12043, it is still an style setting though. For island and islets I reenabled the rendering in #15659 and added in the same commit that mapcss rule for islands.

So, +1 for a Java test that test all place areas if closed or not.

[GerdP]

In 16379/josm:

see #19145: some unclosed ways are not found

• add check for unclosed place=* ways
• remove special mapcss check for unclosed place=island ways

[Klumbumbus]

Milestone renamed