Presets: label suffix/unit at end of text input box

[simon04]

From ticket:8180

Label units at end of text input box:

<text key="somekey" text="Long" unit="m"/>

[simon04]

Presumably, we'd also need to support <combo>. Maybe we'd also need i18n.

<item name="Pipeline">
  <combo key="diameter" text="Diameter" suffix="mm" values="800,1000" />
  <text key="pressure" text="Pressure" suffix="bar" />
</item>

I'm not convinced that this feature is a big improvement – WONTFIX? Any thoughts?

[skyper]

Replying to simon04:

…
I'm not convinced that this feature is a big improvement – WONTFIX? Any thoughts?

It will be more interesting if you could set a different unit which will be added to the value and if the unit is demanded like in #11253 without a default unit.

[Klumbumbus]

It is not so good for cases like maxspeed where you set no unit if kph but set the unit if mph.

[skyper]

I think about a combo for units right (for some languages left) of the value in order to choose the unit. For demanded units like in #11253 with an option to always include the unit otherwise omit the default unit (first position in the list) which should be the default setting.

[simon04]

I see a lot of trouble to get this feature done properly: unit conversion yes/no, splitting apart and joining tags, with/without space between value and unit, tags with multiple values (220kV;380kV), expert users are annoyed because they have to use two separate input fields, …

I won't work on this feature in the foreseeable future.

[Klumbumbus]

Replying to simon04:

I see a lot of trouble to get this feature done properly

I too. Wontfix?

[simon04]

If anyone is interested to work on this, feel free to reopen.

[gaben]

I have a new idea. It is less intrusive than the original solution and maybe easier to implement. Wikipedia plugin already does this on wikidata keys:

So the idea is, to put the default unit next to the value. If an explicit unit is provided, there is no need to show anything. Because of this, it would work on combo keys. This can maybe be applied to MapCSS as well because a number without context doesn't mean anything.

I see possible problems with this approach. There are generic keys, like capacity which used from parking slots to storage tanks. To show cubic metre for a storage tank first there should be information about the preset, that is not a parking slot, but a thing with volume (=cubic metre).

For default units, see ​https://wiki.openstreetmap.org/wiki/Map_Features/Units

What do you think?

[gaben]

the grey text is added by Wikipedia plugin

[simon04]

@gaben, your suggestion is somewhat similar to comment:1. Still, there isn't a big advantage compared to what we're doing now – writing the default units in parentheses.

Let's reopen this ticket for some further discussion/evaluation.

[Klumbumbus]

Milestone renamed

[gaben]

@simon04: Yeah maybe, it depends. When someone doing QA, it is better to see all the information at once. Currently, to see those units what you mentioned, one should open the preset editor which is an unnecessary extra step in my opinion.