Context Navigation

Modify ↓

#18722 closed defect (fixed)

Mapillary json exception

Reported by:	StephaneP	Owned by:	Don-vip
Priority:	normal	Milestone:	20.02
Component:	Core geojson	Version:
Keywords:	template_report, json	Cc:

Description

What steps will reproduce the problem?

Drag & drop a folder containing images already upload to Mapillary. Or simply drag & drop the mapillary json file.

What is the expected result?

Josm load the images

What happens instead?

Josm load the images and an exception occured

Please provide any additional information below. Attach a screenshot if possible.

Folder with some images already uploaded to Mapillary, usually contain a small json file that Josm doesn't like.
I think Josm should silently ignore it.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-01 01:10:57 +0100 (Sat, 01 Feb 2020)
Build-Date:2020-02-01 00:12:46
Revision:15806
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15806 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1903 (18362)
Memory Usage: 6075 MB / 14564 MB (3140 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ DirectUpload (35248)
+ Mapillary (1.5.20)
+ OpeningHoursEditor (35250)
+ PicLayer (35313)
+ PolygonCutOut (v0.7)
+ apache-commons (35092)
+ apache-http (35092)
+ cadastre-fr (35308)
+ changeset-viewer (22)
+ continuosDownload (91)
+ contourmerge (v0.1.5)
+ ejml (35122)
+ geotools (35169)
+ graphview (35313)
+ imagery-xml-bounds (35313)
+ indoorhelper (35312)
+ javafx-windows
+ jaxb (35092)
+ jna (35092)
+ jts (35122)
+ measurement (35248)
+ opendata (35313)
+ photo_geotagging (35313)
+ photoadjust (35313)
+ poly (35248)
+ reverter (35313)
+ tageditor (35258)
+ todo (30306)
+ turnlanes-tagging (283)
+ turnrestrictions (35313)
+ undelete (35313)
+ utilsplugin2 (35248)

Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/FR.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/RecyclingMaterials&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1
- https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1
- http://kolesar.turistautak.hu/osm/opencellid/api/styles/measurements.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&zip=1
- <josm.pref>\styles\bicycle\cycleway.mapcss
- <josm.pref>\styles\sit.mapcss

Last errors/warnings:
- W: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.UnknownHostException: api.openstreetmap.org
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: Deleted or moved objects - <html>There is 1 object in your local dataset which might be deleted on the server.<br>If you later try to delete or update this the server is likely to report a conflict.<br>Click <strong>Check on the server</strong> to check the state of this object on the server.<br>Click <strong>Ignore</strong> to ignore.</html>
- E: Handled by bug report queue: java.lang.NullPointerException
- E: Handled by bug report queue: java.lang.NullPointerException


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: main-worker-0 (67) of main
java.lang.NullPointerException
	at org.glassfish.json.JsonObjectBuilderImpl$JsonObjectImpl.getString(JsonObjectBuilderImpl.java:257)
	at org.openstreetmap.josm.io.GeoJSONReader.parseRoot(GeoJSONReader.java:76)
	at org.openstreetmap.josm.io.GeoJSONReader.parse(GeoJSONReader.java:68)
	at org.openstreetmap.josm.io.GeoJSONReader.doParseDataSet(GeoJSONReader.java:352)
	at org.openstreetmap.josm.io.GeoJSONReader.parseDataSet(GeoJSONReader.java:369)
	at org.openstreetmap.josm.gui.io.importexport.GeoJSONImporter.importData(GeoJSONImporter.java:51)
	at org.openstreetmap.josm.gui.io.importexport.FileImporter.importDataHandleExceptions(FileImporter.java:95)
	at org.openstreetmap.josm.actions.OpenFileAction$OpenFileTask.importData(OpenFileAction.java:369)
	at org.openstreetmap.josm.actions.OpenFileAction$OpenFileTask.realRun(OpenFileAction.java:319)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:94)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:142)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

Attachments (1)

mapillary_import_summary.json (853 bytes ) - added by StephaneP 4 years ago.

Download all attachments as: .zip

Change History (5)

by StephaneP, 4 years ago

Attachment:	mapillary_import_summary.json added

comment:1 by Don-vip, 4 years ago

Component:	Core → Core geojson

comment:2 by simon04, 4 years ago

GeoJSONImporter should not handle attachment:mapillary_import_summary.json

Maybe we should exclude .json from the list of supported extensions?

comment:3 by Don-vip, 4 years ago

Milestone:	→ 20.02
Owner:	changed from team to Don-vip
Status:	new → assigned

comment:4 by Don-vip, 4 years ago

Resolution:	→ fixed
Status:	assigned → closed

In 15865/josm:

fix #18722 - exclude json file extension from GeoJsonImporter + add robustness

Modify Ticket

Change Properties

Summary:
Type:		Priority:
Milestone:		Component:
Version:		Keywords:
Cc:	Set your email in Preferences

Action

leave as closed The owner will remain Don-vip.

change resolution as The resolution will be set.

reopen The resolution will be deleted. Next status will be 'reopened'.

Add Comment

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.

Download in other formats: