Overwrite key - Windows's layout [patch]

[StephaneP]

Hi!

Sometimes, it's difficult to compare the values when you overwrite a key. It could easier to read if the new values are display below the original. (Some carrier return to add)

Actual layout

Example for a new layout

[StephaneP]

actual layout

[StephaneP]

new_layout

[Klumbumbus]

In 17061/josm:

see #18721 - Use better icon for replace value dialog, "purge" didn't fit well here.

[Klumbumbus]

The whole dialog is a bit confusing because the line "The new key is already used..." belongs to the other dialog when you edit the key of an existing tag to an already existing key. This line doesn't fit well here when you try to add a new tag and the key already exists.

Also it asks to "overwrite" which must be confirmed with "Replace". Using the same word is more intuitive for the user.

I'm working on a patch...

[Klumbumbus]

TagEditHelper.java

@@ -407 +407 @@
     private static boolean warnOverwriteKey(String action, String togglePref) {
         return new ExtendedDialog(
                 MainApplication.getMainFrame(),
-                tr("Overwrite key"),
-                tr("Replace"), tr("Cancel"))
+                tr("Overwrite tag"),
+                tr("Overwrite"), tr("Cancel"))
             .setButtonIcons("ok", "cancel")
-            .setContent(action+'\n'+ tr("The new key is already used, overwrite values?"))
+            .setContent(action+'\n'+ tr("Overwrite?"))
             .setCancelButton(2)
             .toggleEnable(togglePref)
             .showDialog().getValue() == 1;
@@ -543 +543 @@
             } else {
                 for (OsmPrimitive osm: sel) {
                     if (osm.get(newkey) != null) {
-                        if (!warnOverwriteKey(tr("You changed the key from ''{0}'' to ''{1}''.", key, newkey),
+                        if (!warnOverwriteKey(tr("You changed the key from ''{0}'' to ''{1}''. The new key is already used.", key, newkey),
                                 "overwriteEditKey"))
                             return;
                         break;
@@ -1099 +1099 @@
             for (OsmPrimitive osm : sel) {
                 String val = osm.get(key);
                 if (val != null && !val.equals(value)) {
-                    if (!warnOverwriteKey(tr("You changed the value of ''{0}'' from ''{1}'' to ''{2}''.", key, val, value),
+                    if (!warnOverwriteKey(tr("You changed the value of ''{0}''.\nOld and new value are:\n\n{1}\n{2}\n", key, val, value),
                             "overwriteAddKey"))
                         return;
                     break;

[stoecker]

You changed the value of ''{0}''.\nOld and new value are:\n\n{1}\n{2}\n

This looks worse than before to me.

[Klumbumbus]

This is with the patch:

[Klumbumbus]

The problem with just adding line breaks without rewording is regarding translation. E.g. in german you would need one more line than in english. I think thats not so optimal either.

You changed the value of
residenital
to
residential
Overwrite?

Du hast den Wert von
residenital
zu
residential
geändert
Überschreiben?

[StephaneP]

Another solution:
---
You changed an already existing value. Overwrite?

old: residenital
new: residential

---
Du hast einen bereits vorhandenen Wert geändert. Überschreiben?

alt: residenital
neu: residential
---
the old and new value should be verticaly aligned.

[stoecker]

Replying to StephaneP:

the old and new value should be verticaly aligned.

Also had this idea, but the vertical alignment is not so trivial for translations.

Maybe use colors instead of words? red:old, new:green?

[skyper]

There is another problem. This warning does not check the value. Adding the existing value still triggers this warning but I do not change or replace any existing tag. E.g. have building=yes and building:part=yes. Changing building:part to building triggers this warning.

[simon04]

We could also reuse the red/green colouring of the history dialog (Help/Action/ObjectHistory#Overview), potentially displayed as two rows/lines (1st=old, 2nd=new)?

[anonymous]

Replying to simon04:

We could also reuse the red/green colouring of the history dialog (Help/Action/ObjectHistory#Overview), potentially displayed as two rows/lines (1st=old, 2nd=new)?

Please still prefix it with old & new in that case, if it's not obvious which is which. #colorblind :)

[simon04]

In 17168/josm:

fix #18721 - PropertiesDialog: improve "overwrite key" dialog (based on patch by StephaneP)

[Don-vip]

Milestone renamed