[Patch] Route of type aerialway should contain "stop"

[pch14@…]

What steps will reproduce the problem?

1. A legacy route relation (cable car)
2. Mark stop and end stations as "stop"
3. Error, stop not in template (like in e.g. railway)

What is the expected result?

aerialway should allow stops too

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-01 01:10:57 +0100 (Sat, 01 Feb 2020)
Build-Date:2020-02-01 00:12:46
Revision:15806
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15806 de) Linux Ubuntu 18.04.4 LTS
Memory Usage: 970 MB / 2196 MB (408 MB allocated, but free)
Java version: 1.8.0_181-b13, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1280x1024
Maximum Screen Size: 1280x1024
fonts-noto: fonts-noto:all-20171026-2
VM arguments: [-Djosm.restart=true, -Djava.net.useSystemProxies=true]
Program arguments: [/run/user/1000/gvfs/mtp:host=%5Busb%3A003%2C012%5D/Interner gemeinsamer Speicher/Download/Rastlboden.gpx]
Dataset consistency test: No problems found

Plugins:
+ reverter (35313)
+ undelete (35313)
+ utilsplugin2 (35248)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/sac_scale&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

[Don-vip]

Can you please share an .osm file showing the problem?

[anonymous]

Sample .osm to replicate the (IMO) spurious warning

[anonymous]

Though this kind of route is not documented in the Wiki, there are some in the Wild, ​https://taginfo.openstreetmap.org/tags/route=aerialway So it might make sense to have a template for this.

[simon04]

Currently, OSM has 181 relations of route=aerialway

[skyper]

The bigger problem is the false positive in validator check:
Role verification problem - Role of relation member does not match template expression 'highway=bus_stop || railway=station || railway=halt || railway=tram_stop' in preset Public transport route (Legacy)

Tried it with aerialway=station + public_transport=stop_position and aerialway=yes + public_transport=stop_position.

[skyper]

How about splitting the legacy route relation preset into three, one for rail, one for bus/share_taxi and one for the rest?

[skyper]

See #17661 for problems with ferry route relations.

[skyper]

patch adding ptv1 and ptv2 route relations for ferry and aerialway

[skyper]

Please, find attached patch file​ also solving #17661.

As ferry has some different tags I had to handle it in an own preset. For better validation on members I added both, a ptv1 and a ptv2 version relations.

[skyper]

Ping

Do these changes need further discussion?
As #18949 was fixed, there is more room for improvements, but that can be handled in a separate patch.

[skyper]

I would go on and add automatically created name values (#18949) but please tell me if my way in splitting the presets is acceptable or where you see/have problems with it. Thanks

[skyper]

Ping.

@team:
Would you please tell me, if splitting into more individual presets for relations is the way to go. What are your opinions about the role problematic and how to solve it?

Thanks

[skyper]

Ping

[skyper]

Replying to skyper:

Do these changes need further discussion?

???

As #18949 was fixed, there is more room for improvements, but that can be handled in a separate patch.

As #20851 and #20861 should be fixed before introducing value_template in defaultpresets, the patch is ready for commit.

[Don-vip]

The patch no longer applies nicely (sorry) can you please update it? I'll apply it tomorrow.

[skyper]

updated version 2; adds missing type=route to all relations; updates/adds wiki links; allow "Road" + "Access Restriction" for all types

[skyper]

Well I had some glitches in the patch anyway. Please find updated version 2​ which additionally

• adds missing type=route to all presets
• adds/updates wiki links
• allows all object types for "Road" + "Access Restriction" to be able to link to the presets

I was kind of in a hurry and hope I did not mess up or forget that much.

[Don-vip]

In 18204/josm:

fix #17661 - fix #18662 - add ptv1 and ptv2 route relations for ferry and aerialway (patch by skyper)

[skyper]

small update not using "Road Restrictions" anymore

[skyper]

I do not like the preset link to "Road Restrictions". Please, find a small update​ which excludes most max*=* in a chunk and uses this chunk instead of the preset link for ferries.

[Don-vip]

PresetClassificationsTest fails:

https://josm.openstreetmap.de/jenkins/job/JOSM/jdk=JDK8/7550/testReport/org.openstreetmap.josm.gui.tagging.presets/PresetClassificationsTest/testRelationsForTram__/

AssertionFailedError: railway=tram should not match 'Bus' ==> expected: <false> but was: <true>
	at org.openstreetmap.josm.gui.tagging.presets.PresetClassificationsTest.testRelationsForTram(PresetClassificationsTest.java:78)

Can you please check if the test needs to be updated or if something is wrong in presets?

[skyper]

update version 2: removes the second bracket to satisfy test

[skyper]

This test is strange. Two options to satisfy it, again:

• splitting rail and bus for legacy ptv1 relations, as-well
• removing Bus from the general legacy ptv1 relations preset name by simply dropping the second brackets or changing it context to something else

I went with the last and removed the second bracket: josm_17661_18662_v2_update2.patch​

[Don-vip]

In 18210/josm:

fix #18662 - small update not using "Road Restrictions" anymore (patch by skyper)

[Don-vip]

Milestone renamed