Opened 5 years ago
Closed 5 years ago
#18605 closed enhancement (fixed)
Add deprecation for building:height => height
Reported by: | mkoniecz | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | 20.01 |
Component: | Core validator | Version: | |
Keywords: | template_report building height | Cc: |
Description
What steps will reproduce the problem?
- Create closed way
- Add
building=yes
andbuilding:height=100
tags - Run validator
What is the expected result?
building:height
is proposed to be converted to height
What happens instead?
Nothing
Please provide any additional information below. Attach a screenshot if possible.
https://taginfo.openstreetmap.org/keys/building%3Aheight#overview
https://wiki.openstreetmap.org/w/index.php?title=Key:building:height&redirect=no
Is used on building=* and building:part=* where height tag would be perfectly fine and is a pointless duplicate.
And it is yet another thing that need to be handled during data processing (see for example westnordost/StreetComplete@e4897e9#diff-c3d4cf73bd9fd9dabd89d5ed73b9995bR21 ), without any benefit whatsoever.
iD issue: https://github.com/openstreetmap/iD/issues/7285
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2020-01-15 18:25:57 +0100 (Wed, 15 Jan 2020) Revision:15713 Build-Date:2020-01-16 02:30:53 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (15713 en_GB) Linux Ubuntu 19.10 Memory Usage: 230 MB / 976 MB (62 MB allocated, but free) Java version: 11.0.5+10-post-Ubuntu-0ubuntu1.1, Private Build, OpenJDK 64-Bit Server VM Screen: :0.0 1920x1080 Maximum Screen Size: 1920x1080 Java package: openjdk-11-jre:amd64-11.0.5+10-0ubuntu1.1 Java ATK Wrapper package: libatk-wrapper-java:all-0.35.0-3 libcommons-logging-java: libcommons-logging-java:all-1.2-2 fonts-noto: fonts-noto:- Dataset consistency test: No problems found Last errors/warnings: - W: No configuration settings found. Using hardcoded default values for all pools. - W: Region [TMS_BLOCK_v2] Resetting cache
There is also building:min_height (800 uses).
https://taginfo.openstreetmap.org/keys/building%3Amin_height