Show continuity line next to sub route relations members of route relations/ Node/Way cannot be cast to org.openstreetmap.josm.data.osm.Relation

[Polyglot]

What steps will reproduce the problem?

1. I converted my bus route relation to a type=superroute / superroute=bus

What is the expected result?

Continuity lines next to the relations containing ways

What happens instead?

One exception after another, the first ones - which I tried to ignore - referred to nodes, this one to a way

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-01-20 23:45:26 +0100 (Mon, 20 Jan 2020)
Build-Date:2020-01-21 02:30:56
Revision:15743
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15743 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1903 (18362)
Memory Usage: 369 MB / 725 MB (201 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1920x1080, \Display1 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.20)
+ apache-commons (35092)
+ apache-http (35092)
+ buildings_tools (35248)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35092)
+ jna (35092)
+ jts (35122)
+ opendata (35280)
+ pt_assistant (34678)
+ reverter (35248)
+ todo (30306)
+ utilsplugin2 (35248)
+ wikipedia (1.1.3)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NumberedCycleNodeNetworks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Cycleways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NumberedCycleNodeNetworks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NumberedWalkingNodeNetworks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1

Last errors/warnings:
- E: Handled by bug report queue: java.lang.ClassCastException: org.openstreetmap.josm.data.osm.Node cannot be cast to org.openstreetmap.josm.data.osm.Relation
- E: Handled by bug report queue: java.lang.ClassCastException: org.openstreetmap.josm.data.osm.Node cannot be cast to org.openstreetmap.josm.data.osm.Relation
- E: Handled by bug report queue: java.lang.ClassCastException: org.openstreetmap.josm.data.osm.Node cannot be cast to org.openstreetmap.josm.data.osm.Relation
- E: Handled by bug report queue: java.lang.ClassCastException: org.openstreetmap.josm.data.osm.Node cannot be cast to org.openstreetmap.josm.data.osm.Relation
- E: Handled by bug report queue: java.lang.ClassCastException: org.openstreetmap.josm.data.osm.Node cannot be cast to org.openstreetmap.josm.data.osm.Relation
- E: Handled by bug report queue: java.lang.ClassCastException: org.openstreetmap.josm.data.osm.Node cannot be cast to org.openstreetmap.josm.data.osm.Relation
- E: Handled by bug report queue: java.lang.ClassCastException: org.openstreetmap.josm.data.osm.Node cannot be cast to org.openstreetmap.josm.data.osm.Relation
- E: Handled by bug report queue: java.lang.ClassCastException: org.openstreetmap.josm.data.osm.Node cannot be cast to org.openstreetmap.josm.data.osm.Relation
- E: Handled by bug report queue: java.lang.ClassCastException: org.openstreetmap.josm.data.osm.Way cannot be cast to org.openstreetmap.josm.data.osm.Relation
- E: Handled by bug report queue: java.lang.ClassCastException: org.openstreetmap.josm.data.osm.Way cannot be cast to org.openstreetmap.josm.data.osm.Relation


=== REPORTED CRASH DATA ===
WayConnectionTypeCalculator#updateLinks:
 - i: 12
 - member: ""={Relation id=10529971 version=1 VT [way 377814547, way 78579065]}
 - con: 
    - null
    - [P true ;N true ;D NONE ;L false ;FP false;BP false;OH false;OT false]
    - [P true ;N true ;D NONE ;L false ;FP false;BP false;OH false;OT false]
    - [P true ;N true ;D NONE ;L false ;FP false;BP false;OH false;OT false]
    - [P true ;N true ;D NONE ;L false ;FP false;BP false;OH false;OT false]
    - [P true ;N true ;D NONE ;L false ;FP false;BP false;OH false;OT false]
    - [P true ;N true ;D NONE ;L false ;FP false;BP false;OH false;OT false]
    - [P true ;N true ;D NONE ;L false ;FP false;BP false;OH false;OT false]
    - [P true ;N true ;D NONE ;L false ;FP false;BP false;OH false;OT false]
    - [P true ;N true ;D NONE ;L false ;FP false;BP false;OH false;OT false]
    - [P true ;N false ;D NONE ;L false ;FP false;BP false;OH false;OT false]
    - null
    - null
 - members: 
    - ""={Relation id=10529981 version=1 VT [way 114787996, way 114787999]}
    - ""={Relation id=10529980 version=1 VT [way 93479401, way 93479403, way 25093510, way 48284219]}
    - ""={Relation id=10529979 version=1 VT [way 24374859, way 103917268, way 258363837, way 258369821]}
    - ""={Relation id=10529978 version=1 VT [way 48997749, way 429706859, way 174886297, way 608818919, way 310838968]}
    - ""={Relation id=10529977 version=1 VT [way 310838971, way 310838964, way 315609633, way 310838959, way 310838962, way 301552216, way 23119517, way 564556445]}
    - ""={Relation id=10529976 version=1 VT [way 120086151, way 578662085, way 174886295, way 578662084, way 578662083, way 301552215, way 301552213, way 608715630, way 608715634, way 608715632, way 608715635, way 85799069, way 85799351, way 301552211, way 301552210, way 578662070, way 174886300, way 120125393, way 578662068, way 655251291, way 174886292, way 174886289]}
    - ""={Relation id=10529975 version=1 VT [way 3328222, way 3677328, way 3677327, way 439142857, way 608715564, way 608715571, way 608715566, way 608715568]}
    - ""={Relation id=10529974 version=1 VT [way 3351203, way 79002190]}
    - ""={Relation id=10529973 version=1 MVT [way 3343976, way 578662076, way 578662078, way 16767290, way 3343975, way 19793199]}
    - ""={Relation id=10529972 version=1 VT [way 185988814, way 19793223]}
    - ""={Relation id=10529959 version=1 VT [way 81522744, way 89574079]}
    - ""={Way id=79596977 version=4 VT nodes=[{Node id=924451067 version=10 V lat=50.8817839,lon=4.7144213}, {Node id=3812130495 version=2 V lat=50.8818485,lon=4.7145277}]}
    - ""={Relation id=10529971 version=1 VT [way 377814547, way 78579065]}
 - lastWct: [P false ;N false ;D NONE ;L false ;FP false;BP false;OH false;OT false]
 - firstGroupIdx: 0

BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (15) of main
java.lang.ClassCastException: org.openstreetmap.josm.data.osm.Way cannot be cast to org.openstreetmap.josm.data.osm.Relation
	at org.openstreetmap.josm.data.osm.RelationMember.getRelation(RelationMember.java:52)
	at org.openstreetmap.josm.gui.dialogs.relation.sort.WayConnectionTypeCalculator.updateLinksFor(WayConnectionTypeCalculator.java:83)
	at org.openstreetmap.josm.gui.dialogs.relation.sort.WayConnectionTypeCalculator.updateLinks(WayConnectionTypeCalculator.java:60)
	at org.openstreetmap.josm.gui.dialogs.relation.MemberTableModel.getWayConnection(MemberTableModel.java:779)
	at org.openstreetmap.josm.gui.dialogs.relation.MemberTable$ZoomToGapAction.getConnectionType(MemberTable.java:223)
	at org.openstreetmap.josm.gui.dialogs.relation.MemberTable$ZoomToGapAction.hasGap(MemberTable.java:230)
	at org.openstreetmap.josm.gui.dialogs.relation.MemberTable$ZoomToGapAction.updateEnabledState(MemberTable.java:253)
	at org.openstreetmap.josm.gui.dialogs.relation.MemberTable$ZoomToGapAction.valueChanged(MemberTable.java:258)
	at javax.swing.DefaultListSelectionModel.fireValueChanged(Unknown Source)
	at javax.swing.DefaultListSelectionModel.fireValueChanged(Unknown Source)
	at javax.swing.DefaultListSelectionModel.fireValueChanged(Unknown Source)
	at javax.swing.DefaultListSelectionModel.removeIndexInterval(Unknown Source)
	at org.openstreetmap.josm.gui.dialogs.relation.MemberTableModel.remove(MemberTableModel.java:313)
	at org.openstreetmap.josm.gui.dialogs.relation.actions.RemoveAction.actionPerformed(RemoveAction.java:36)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[Polyglot]

Simon, I should first thank you for implementing this. I tried it and there are still some issues with it. Probably because I tried it on a bus route.

[simon04]

In 15747/josm:

see #18591 - fix CCE, fix NPE

[simon04]

This should be fixed (milestone 20.01).