#18590 closed enhancement (fixed)
[PATCH] AddressesTest should split addresses on common delimiters (`,` and `;`)
| Reported by: | taylor.smock | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 20.01 |
| Component: | Core validator | Version: | |
| Keywords: | addresses | Cc: |
Description (last modified by )
https://wiki.openstreetmap.org/wiki/Addresses#Buildings_with_multiple_house_numbers
Example:
addr:housenumber=1,3 addr:street=Example Road vs addr:housenumber=1 addr:street=Example Road + addr:housenumber=3 + addr:street=Example Road.
Attachments (3)
Change History (13)
by , 5 years ago
| Attachment: | 18590.patch added |
|---|
comment:1 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 5 years ago
Replying to Don-vip:
Shouldn't it be renamed to getSimplifiedAddresses?
Yep. Plural makes more sense.
comment:4 by , 5 years ago
| Milestone: | → 20.01 |
|---|
by , 5 years ago
| Attachment: | 18590.3.patch added |
|---|
comment:7 by , 5 years ago
Replying to taylor.smock:
It applied cleanly for me. I'll post another one.
I'm wondering if it is due to me manually editing it, and your patch method doing something different with whitespace? My text editor trims trailing whitespace by default.
comment:10 by , 5 years ago
Replying to Don-vip:
I use Eclipse to apply the patches.
OK. I'll try to remember to test with Eclipse in the future -- I've been using patch -p0 < ${patchfile} in the JOSM source directory when I've said "works for me", and then use that to get a new patch which seems to work for you most of the time.
I suspect that it is a whitespace issue when I manually edit the patches, where patch ignores the whitespace differences and Eclipse doesn't.
Thanks.
Expand
,and;addresses