complain about railway=construction without construction tag

[mkoniecz]

What steps will reproduce the problem?

1. try to make map from OSM data and encounter problems on railway=construction without construction=* tags
2. select railway=construction without construction tag in JOSM
3. run validator

What is the expected result?

Validator complains "construction tag missing for railway=construction"

What happens instead?

No complaints

Please provide any additional information below. Attach a screenshot if possible.

At least for some data consumers there is a difference between tram line under construction and railway=rail line under construction

See equivalent for highway=construction https://josm.openstreetmap.de/ticket/18246#modify

Currently would apply to about 5k objects - see ​https://taginfo.openstreetmap.org/tags/railway=construction#combinations

Complaining on railway=construction=yes + construction=yes may also make sense, but it seems that this mistagging is not very popular

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-12-08 19:47:36 +0100 (Sun, 08 Dec 2019)
Revision:15573
Build-Date:2019-12-09 02:31:01
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (15573 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 326 MB / 978 MB (151 MB allocated, but free)
Java version: 11.0.5+10-post-Ubuntu-2ubuntu116.04, Ubuntu, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-11.0.5+10-2ubuntu1~16.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-6
libcommons-logging-java: libcommons-logging-java:all-1.2-1+build1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35242)
+ PicLayer (35104)
+ apache-commons (35092)
+ buildings_tools (35171)
+ continuosDownload (82)
+ ejml (35122)
+ geotools (35169)
+ imagery_offset_db (34908)
+ jts (35122)
+ log4j (34908)
+ measurement (35221)
+ reverter (35226)
+ todo (30306)

Validator rules:
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Unable to delete archived backup file <josm.userdata>/autosave/deleted_layers/testcase.osm_20191209_182353458.osm

[Klumbumbus]

In 15584/josm:

fix #18411 - warn about railway=construction without construction tag

[Klumbumbus]

In 15648/josm:

• fix #18374 - warn if collection_times is used instead of opening_hours on amenity=recycling, rewording in preset
• see #18411, see #10576 - add railway=construction preset, icon derived from internal rail and way_construction icons, PD and CC0 licensed
• see #18411 - warn about railway=construction or highway=construction together with construction=yes
• see #18517 - restore office=administrative icon in nodist folder, add autofix for office=administrative -> government
• move building=ger to residential building preset
• remove TLD from IANA
• see #18507
  • add kerb=* to crossing and traffic signals preset
  • warn about barrier=kerb together with kerb=no
  • warn about kerb=unknown
  • warn if barrier=kerb and kerb=* are used on isolated nodes
  • warn if barrier=kerb is used on highway=crossing as part of a major road and suggest kerb=* instead
  • deprecate sloped_curb=* in favor of kerb=*
• see #12575 - new craft icons, all PD and CC0 licensed:
  • gardener: derived from internal florist icon and ​https://publicdomainvectors.org/en/free-clipart/Planting-a-new-tree/83454.html
  • shoemaker: resized from ​https://publicdomainvectors.org/en/free-clipart/Brown-shoe/43147.html
  • upholsterer: resized from ​https://publicdomainvectors.org/en/free-clipart/Old-chair-vector-image/71929.html

[Don-vip]

In 15653/josm:

see #18411, see #10576 - remove railway=construction from ignore file