Modify ↓

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16543 closed enhancement (fixed)

[Patch] Enable downloading of Multiple Tracks and use names, add track info to tracks and use tags

Reported by: reubot Owned by: reubot
Priority: normal Milestone:
Component: Plugin DirectDownload Version:
Keywords: Cc:

Description


Attachments (3)

directdownload.patch​ (8.1 KB ) - added by reubot 6 years ago.
directdownload.34484.patch​ (1.9 KB ) - added by reubot 6 years ago.
Fix crash when gpx contains multiple segments
directdownload.34485.patch​ (694 bytes ) - added by reubot 6 years ago.
Fix crash when gpx contains multiple segments

Download all attachments as: .zip

Change History (13)

comment:1 by reubot, 6 years ago

This patch enables downloading of multiple tracks, and sets the track name properly.

comment:2 by Don-vip, 6 years ago

Summary: Enable downloading of Multiple Tracks and use names → [Patch] Enable downloading of Multiple Tracks and use names

comment:3 by Don-vip, 6 years ago

Owner: changed from team to reubot
Status: new → needinfo

Thanks for the patch!

Some remarks to take into account:

  • please run "ant checkstyle" and fix the reported errors
  • please don't comment existing code
  • what's about this TODO?

comment:4 by reubot, 6 years ago

Hi, I have updated the patch to conform to the code style and removed the TODO.

by reubot, 6 years ago

Attachment: directdownload.patch​ added

comment:5 by Don-vip, 6 years ago

Resolution: → fixed
Status: needinfo → closed

Applied in [o34481:34482]. Thanks!

comment:6 by reubot, 6 years ago

Resolution: fixed
Status: closed → reopened
Summary: [Patch] Enable downloading of Multiple Tracks and use names → [Patch] Enable downloading of Multiple Tracks and use names, add track info to tracks and use tags

Hi, sorry to reopen, but I just realised I introduced a crash in the plugin when a gpx file contains more than one segment.

by reubot, 6 years ago

Attachment: directdownload.34484.patch​ added

Fix crash when gpx contains multiple segments

comment:7 by Don-vip, 6 years ago

Resolution: → fixed
Status: reopened → closed

Applied in [o34485:34486].

by reubot, 6 years ago

Attachment: directdownload.34485.patch​ added

Fix crash when gpx contains multiple segments

comment:8 by reubot, 6 years ago

Hi I added a minor update to the last patch (I made a mistake when making the previous diff to the updated JOSM core)

Sorry for all the bother.

Last edited 6 years ago by reubot (previous) (diff)

comment:9 by reubot, 6 years ago

Resolution: fixed
Status: closed → reopened

comment:10 by Don-vip, 6 years ago

Resolution: → fixed
Status: reopened → closed

Applied in [o34593:34594].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain reubot.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.