Error when cancelling uploading edited notes (while server is unreachable)

[Kilkenni]

What steps will reproduce the problem?

1. Process and close some notes (with Notes plugin)
2. Try to upload the changes made with notes to the server

• Important! The server was unreachable at the moment

3. Try to cancel the upload when you see system retrying connection
4. This error appears

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-07-29 00:41:59 +0200 (Sun, 29 Jul 2018)
Build-Date:2018-07-29 01:32:17
Revision:14066
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14066 uk) Windows 7 64-Bit
OS Build number: Windows 7 Ultimate (7601)
Memory Usage: 461 MB / 1820 MB (86 MB allocated, but free)
Java version: 1.8.0_181-b13, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1280x1024
Maximum Screen Size: 1280x1024
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Portable\JOSM\josm.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=56470, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ EasyPresets (1529414338)
+ ImproveOsm (137)
+ Mapillary (v1.5.15)
+ OpeningHoursEditor (34389)
+ PicLayer (34389)
+ TombPlugin (55)
+ apache-commons (34389)
+ apache-http (34389)
+ buildings_tools (34212)
+ ejml (34389)
+ geochat (34389)
+ geotools (34125)
+ graphview (34389)
+ imagery_offset_db (34370)
+ jts (34206)
+ log4j (34038)
+ reltoolbox (34346)
+ reverter (34271)
+ tagging-preset-tester (34109)
+ utilsplugin2 (34389)
+ wikipedia (v1.0.2)

Tagging presets:
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/UA.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Quick-highways&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Quick-stops&zip=1
+ http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/s3db-preset.zip
+ C:\Portable\JOSM\bank-atm-preset-test.xml
+ C:\Portable\JOSM\building-extended-preset-test.xml
+ C:\Portable\JOSM\historic-places-preset-test.xml
+ C:\Portable\JOSM\industrial-preset-test.xml
+ C:\Portable\JOSM\obstacles-preset-test.xml
+ C:\Portable\JOSM\street-artwork-preset-test.xml
+ C:\Portable\JOSM\forest-presets.xml

Map paint styles:
- <josm.pref>\styles\sit.mapcss

Validator rules:
- <josm.pref>\validator\indoorhelper.validator.mapcss

Last errors/warnings:
- W: org.openstreetmap.josm.io.OsmApiException: ResponseCode=500
- E: Failed to upload note to server: 1 423 531
- E: org.openstreetmap.josm.io.OsmTransferCanceledException: Operation canceled
- E: Failed to upload note to server: 1 044 778
- E: org.openstreetmap.josm.io.OsmTransferCanceledException: Operation canceled
- E: Failed to upload note to server: 1 021 758
- E: org.openstreetmap.josm.io.OsmTransferCanceledException: Operation canceled
- E: Notes failed to upload: Нотатка 1 021 758, збій: Operation canceled
- E: org.openstreetmap.josm.io.OsmTransferCanceledException: Operation canceled
- E: Handled by bug report queue: org.openstreetmap.josm.io.OsmTransferCanceledException: Operation canceled


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (60) of javawsApplicationThreadGroup
org.openstreetmap.josm.io.OsmTransferCanceledException: Operation canceled
	at org.openstreetmap.josm.io.OsmApi.sleepAndListen(OsmApi.java:600)
	at org.openstreetmap.josm.io.OsmApi.sendRequest(OsmApi.java:698)
	at org.openstreetmap.josm.io.OsmApi.closeNote(OsmApi.java:861)
	at org.openstreetmap.josm.actions.upload.UploadNotesTask$UploadTask.processNoteComment(UploadNotesTask.java:94)
	at org.openstreetmap.josm.actions.upload.UploadNotesTask$UploadTask.realRun(UploadNotesTask.java:74)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:95)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:143)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

[Don-vip]

In 14170/josm:

fix #16542 - don't display error dialog when notes upload is canceled