"Open in browser" should support multiple objects

[nyurik]

Just like history viewer, open in browser should allow to open multiple browser tabs, and warn if too many objects are selected.

Edit
Selecting "View Wikipedia article" opens Wikipedia main page instead of all selected articles:

[Don-vip]

This is already implemented:

Or I didn't understand what you're asking.

[nyurik]

When I right-click on an objet in the selection panel, I can open corresponding Wikipedia entry (I think wikipedia plugin does this, but it may be website linker plugin), it only shows one Wikipedia page. If I have multiple objects selected, only the current one is shown. If I select all lines in the selected panel, it still shows just the current one. Lastly, if I right click on the "wikipedia" tag in the object tag editor panel, and it shows multiple values, it opens Wikipedia's main page instead of all of them.

[Don-vip]

In 15376/josm:

see #14465 - allow plugins to retrieve selected tags with multiple values

[Don-vip]

First part coded in [o35134].

[Don-vip]

regression: #18253

[simon04]

Since r15673, all Wikipedia articles are shown in the popup: Their target is shown as tooltip. Is this sufficient?

[nyurik]

I would say this is actually worse than before. Having a huge list of identical items, without any ability to scroll the context menu beyond the screen height (so impossible to access lower items), and without any clue of which corresponds to what until I mouse over it (so I have to go one-by-one through them), makes the feature far less useful.

On top of that, most of the time I want to open all unique wikipedia/wikidata tabs for a set of object. With this feature, I can only access one at time.

[Don-vip]

Indeed the UI is a huge problem right now. On relations with many tags the links take all the screen space:

[simon04]

In 15706/josm:

see #14465 -Tag2Link: combine links with same name and launch at once

[simon04]

In 15707/josm:

see #14465 -Tag2Link: consider all selected primitives/properties

[simon04]

Now, multiple links with the same name are combined and can be launched at once. Also, all selected properties (from PropertiesDialog), relations (from MembershipDialog and RelationListDialog), primitives (from SelectionListDialog) are taken into account.

[Don-vip]

Nice!

[Don-vip]

We could also add specific icons for Wikipedia, Wikidata and Wikimedia Commons. I guess they're free.

[Don-vip]

Replying to simon04:

Now, multiple links with the same name are combined and can be launched at once.

I'm not sure this the way to go for name:* tags when I right click an object. I'm only interested in the name tag matching (my) JOSM language, and not all the (sometimes 30+) others.

[nyurik]

Exciting, thanks for working on it! One note though -- I noticed that when i searched for many objects with wikidata tag, and right clicked on the wikidata tag's values, I see menu items like "Open in Wikidata Qnnnn", where that nnnn is different on each line. Will your fix handle that? Thx!

[Klumbumbus]

Replying to nyurik:

I see menu items like "Open in Wikidata Qnnnn", where that nnnn is different on each line. Will your fix handle that? Thx!

Thats already fixed in r15706. Please try josm latest version tomorrow.

[nyurik]

Tried it, looks very good, thanks!

[Klumbumbus]

In 15709/josm:

see #14465 - adapt unit test to r15706

[simon04]

In 15711/josm:

see #14465 - Tag2Link: restrict names by JOSM language