requirement of bounds in maps

[Klumbumbus]

It seems JOSM requires min/max bounds even when a shape is present.

The ​XML file from ELI has only shapes but no bounds.

This results in two problems:

• When using the ELI index no polygons are drawn at the minimap at Help/Preferences/Imagery

• Copying entries from ELI to JOSM is not simply possible since the JOSM wiki doesn't allow entries without bounds (and it wouldn't work then anyway)

To me it seems the bounds information is superfluous if a shape is present. So could JOSM correctly handle and allow imagery entries which have a shape but no bounds?

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-11-13 03:19:10 +0100 (Sun, 13 Nov 2016)
Build-Date:2016-11-13 02:34:00
Revision:11249
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11249 de) Windows 7 32-Bit
Memory Usage: 346 MB / 870 MB (127 MB allocated, but free)
Java version: 1.8.0_111-b14, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest-bla.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,900m, -Djnlpx.splashport=49669, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]

[Klumbumbus]

There are a lot imagico.de OSM images for mapping imageries missing in JOSM. They could quickly be copied from ELI once this problem is fixed.

[stoecker]

Rather than adapting JOSM I'd suggest to fix the XML conversion script, so that bounds are added - a fix to JOSM nevertheless would require adding bounds, as it will take longer time until all old installations are updated.

I'm not totally sure about internal tests in JOSM, but I hope than before checking all the polygons first the bounds are checked, so that more complex calculations are not done when already outside of the rectangular bounds.

[simon04]

Replying to stoecker:

Rather than adapting JOSM I'd suggest to fix the XML conversion script, so that bounds are added

Done: ​https://github.com/osmlab/editor-layer-index/commit/846fcc2e285795cd1820d7455e30daaead6730d5

[Klumbumbus]

Replying to simon04:

Done: ​https://github.com/osmlab/editor-layer-index/commit/846fcc2e285795cd1820d7455e30daaead6730d5

Great. One more thing: Could you change the indentation from 2 spaces to 4 spaces at ​https://github.com/osmlab/editor-layer-index/blob/gh-pages/imagery.xml. It shouldn't hurt there and would better fit to the JOSM lists.

[stoecker]

Replying to Klumbumbus:

Replying to simon04:

Done: ​https://github.com/osmlab/editor-layer-index/commit/846fcc2e285795cd1820d7455e30daaead6730d5

Great. One more thing: Could you change the indentation from 2 spaces to 4 spaces at ​https://github.com/osmlab/editor-layer-index/blob/gh-pages/imagery.xml. It shouldn't hurt there and would better fit to the JOSM lists.

But keep in mind, that this ouput is designed to be input to JOSM. Our maps output is also totally stripped to reduce size. Only the wiki has indentation.

[Klumbumbus]

Replying to stoecker:

Replying to Klumbumbus:

Replying to simon04:

Done: ​https://github.com/osmlab/editor-layer-index/commit/846fcc2e285795cd1820d7455e30daaead6730d5

Great. One more thing: Could you change the indentation from 2 spaces to 4 spaces at ​https://github.com/osmlab/editor-layer-index/blob/gh-pages/imagery.xml. It shouldn't hurt there and would better fit to the JOSM lists.

But keep in mind, that this ouput is designed to be input to JOSM. Our maps output is also totally stripped to reduce size. Only the wiki has indentation.

OK, it is not really necessary to change this. One can quickly change the indentation in notepad++ for the whole file and copy then from there.

[Klumbumbus]

This is actually fixed.