Support some presets in multipolygons

[naoliv]

I was trying to add an amenity=dentist in a multipolygon and saw that The preset cannot be applied since the selection is unsuitable!

​http://wiki.openstreetmap.org/wiki/Tag:amenity%3Ddentist doesn't forbid to use it in multipolygons nor I can see why it's invalid.

Doing a quick test I saw that hospital, museum and pitch aren't also allowed.
It seems that all presets should be reviewed to allow their usage (if it's valid, of course) in multipolygons, when necessary.

JOSM:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-01-20 08:46:24 +0100 (Wed, 20 Jan 2016)
Build-Date:2016-01-20 07:48:21
Revision:9548
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9548 pt_BR) Linux Debian GNU/Linux testing (stretch)
Memory Usage: 1228 MB / 9102 MB (738 MB allocated, but free)
Java version: 1.8.0_72-internal-b05, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

[Klumbumbus]

Currently the following "object types" are availible in josm presets: node, way, closedway and relation. There is no multipolygon. So allowing relation for all the shops would mean to allow all types of relation and not just multipolygons. This wouldn't be good in my opinion.
I think the best solution would be to support "multipolygon" as own object type.

It is not forbidden to use multipolygons for shops, but I think this is not necessary in most cases. Better keep the data simple.

[Don-vip]

In 9574/josm:

see #12412 - add a new preset type "multipolygon". TODO: make a better icon

[Don-vip]

@zermes: could you please look if we could get a nice multipolygon icon, consistent with Mf_closedway.svg, Mf_node.svg, Mf_relation.svg, Mf_way.svg?

[Don-vip]

In 9587/josm:

see #12412 - improve multipolygon presets

[Don-vip]

In 9588/josm:

see #12412 - improve support of multipolygon presets type

[Mkyral]

Muůtipolygon icon

[Mkyral]

Something like this?

[Don-vip]

Replying to Mkyral:

Something like this?

yes, perfect! thanks :)

[Don-vip]

In 9615/josm:

fix #12412 - add new icon for multipolygon preset type (by Mkyral) + fix checkstyle violation

[Don-vip]

In 9632/josm:

fix #12443 - NPE (regression from r9588, see #12412)

[Klumbumbus]

In 9638/josm:

see #12412 - add multipolygon preset type to some more presets

[Don-vip]

In 9716/josm:

fix #12467, see #12412 - presets no longer fit correct for boundary relations (regression from r9574)

[Klumbumbus]

see #13536 for a regression