#11710 closed enhancement (fixed)
[Patch] Re-geotagging hides pictures that are not covered by gpx track
Reported by: | skorbut | Owned by: | Bjoeni |
---|---|---|---|
Priority: | normal | Milestone: | 21.05 |
Component: | Core image mapping | Version: | |
Keywords: | Cc: |
Description
There is a somewhat special condition where JOSM/the photo geotagging plugin doesn't behave ideally:
- Load some geotagged images in JOSM
- Try to correlate those images using a gpx track which only covers some, but not all of the images (use the option 'Override position for images with geo location in exif data', otherwise the images wont be repositioned)
- Images that were not covered by the gpx track disappear, although they still have the original geotagging.
- (Writing the coordinates to the files that are covered by the gpx track and reloading all images into JOSM displays everything again in correct fashion. So the situation is not too bad...)
This happened to me in the following situation: I have a camera with an integrated, rather low-quality GPS. To improve the accuracy I also have an external logger whose gpx track is of better quality and that I want to use as a primary source of geotagging. When the battery of the external logger was exhausted, the camera still recorded the (low-quality) position that I would prefer to use if the alternative was to discard the image completely.
Attachments (2)
Change History (16)
comment:1 by , 6 years ago
Owner: | changed from | to
---|
comment:2 by , 3 years ago
Component: | Plugin photo_geotagging → Core image mapping |
---|---|
Owner: | changed from | to
comment:3 by , 3 years ago
Summary: | Re-geotagging hides pictures that are not covered by gpx track → [Patch] Re-geotagging hides pictures that are not covered by gpx track |
---|
comment:4 by , 3 years ago
Milestone: | → 21.05 |
---|
comment:6 by , 3 years ago
@Simon (or someone else)
could you please commit this patch in the near future? #20795 depends on it (or it would at least conflict, so it's easier when this one is committed before I provide a patch for the other one)
comment:7 by , 3 years ago
This patch breaks the unit test org.openstreetmap.josm.data.gpx.GpxImageCorrelationTest#testMatchGpxTrack
comment:9 by , 3 years ago
Fixed that (note to self: shouldn't change a patch after running the tests...). Sorry about that.
I also added another ImageEntry i7
to testMatchGpxTrack
(testing the changes of this ticket).
by , 3 years ago
Attachment: | 11710-V2.patch added |
---|
comment:10 by , 3 years ago
Btw. I just noticed that checkstyle complains that the testMatchGpxTrack()
method is now too long (157 executable statements). I'll change that.
by , 3 years ago
Attachment: | 11710-V3.patch added |
---|
Prevent removal of geotags from files that weren't matched to the track:
-- see new patch below --
See also the changes from #16681 allowing the user to determine what images should be matched.