Jenkins Job Nexus-JOSM-Plugins fails

[GerdP]

Seems the code in plugin pmtiles cannot be compiled with java 8 since
https://josm.openstreetmap.de/changeset/36219/osm

See https://josm.openstreetmap.de/jenkins/job/Nexus-JOSM-Plugins/

[taylor.smock]

It has never been able to be compiled with Java 8. See r36112/osm.
I'll have to investigate why that is happening tomorrow.

[taylor.smock]

It looks like it is just the way the job is written.
Here is a (slightly) cleaned up version.

for pluginjar in ${CHANGED_JARS}; do
    artifactId=$(basename "$pluginjar" .jar)
    id=`echo $artifactId | sed -e 's/-unixoid//g' | sed -e 's/-windows//g' | sed -e 's/-osx//g'`
    cd $BASEDIR/$id && ant clean dist && ${MVN DEPLOY}
done

I'll fiddle with the script to see if I can parse out the minimum Java version for a plugin and build with that.

[taylor.smock]

In 36221/osm:

See #23535: Make jar modification to see if Jenkins changes work

[taylor.smock]

In 36222/osm:

See #23535: Make jar modification to see if Jenkins changes work

[taylor.smock]

OK. It should be fixed for plugins requiring newer versions of Java.

Notes on changes:

• Extract build and publish actions into functions for readability
  • build function uses the expected java version to set the JAVA_HOME environment variable and the javadoc.executable
• Add a build_and_publish function to make it easier to debug (I should have done this first...)
• Add a java_version function to get the expected Java version for the plugin
  • build.xml -- looks for java.lang.version, must match <property name="java.lang.version" value="([0-9]+)" */>
  • pom.xml -- looks for maven.compiler.release, must match <maven.compiler.release>([0-9]+)</maven.compiler.release>
  • gradle.properties -- looks for plugin.minimum.java.version, must match plugin.minimum.java.version=([0-9]+)