Modify

Opened 16 years ago

Closed 16 years ago

#966 closed defect (fixed)

Draw large GPS points does not work if lines between poins are drawn

Reported by: osm@… Owned by: Henry Loenwind
Priority: minor Milestone:
Component: Core Version: latest
Keywords: GPXLayer Cc:

Description

If in preferences, display settings both options "Draw lines between raw gps points." and "Draw large GPS points" are marked then GPS points are not visible on track. This is regression.

Version 662. Previous version used by me was about two week old. There was no such problem there.

Attachments (1)

patch3.diff (17.1 KB ) - added by Henry Loenwind 16 years ago.
GPXLayer fixes and Config dialog additions

Download all attachments as: .zip

Change History (8)

comment:1 by Henry Loenwind, 16 years ago

Keywords: GPXLayer added
Owner: changed from framm to Henry Loenwind
Priority: majorminor

oops, I broke it.

I'll supply a fix next weekend, I don't have my development environment with me and I don't want to submit an untested patch.

BTW: drawing small points while drawing lines is not needed, is it?

comment:2 by Henry Loenwind, 16 years ago

Owner: changed from Henry Loenwind to anonymous
Status: newassigned

comment:3 by Henry Loenwind, 16 years ago

Owner: changed from anonymous to Henry Loenwind
Status: assignednew

comment:4 by Jan Górski <osm@…>, 16 years ago

Well, I think that question about small points between lines is a little bit rhetorical :)

comment:5 by Henry Loenwind, 16 years ago

Ok, here is the patch.

(1) Logic fixed
(2) More speedups with GPS tracks
(3) Added the settings to the config dialog
(4) Removed code for "triangle lines"---they are faster but just to ugly

Note:

  • "Color tracks by velocity." now imposes NO speed penalty to drawing at all.
  • Small points are only drawn when there is no lines pointing there.
  • Enabling large points will slow drawing down a little bit.
  • Same for arrow heads.
  • Same for not enabling "fast draw" for arrow heads.

by Henry Loenwind, 16 years ago

Attachment: patch3.diff added

GPXLayer fixes and Config dialog additions

in reply to:  4 comment:6 by Henry Loenwind, 16 years ago

Replying to Jan Górski <osm@slimak.info>:

Well, I think that question about small points between lines is a little bit rhetorical :)

Not really. When color-lines-by-velocity is enabled, those points would be visible...

comment:7 by ramack, 16 years ago

Resolution: fixed
Status: newclosed

patch applied in [721]

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Henry Loenwind.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.