[Patch] historic=wayside_shrine optional tags

[anonymous]

​http://josm.openstreetmap.de/browser/josm/trunk/data/defaultpresets.xml#L5480

		<item name="Wayside Shrine" icon="presets/wayside_shrine.png" type="node,closedway">
			<label text="Edit Wayside Shrine" />
			<space />
			<key key="historic" value="wayside_shrine" />
			<key key="religion" value="christian" />
			<key key="building" value="wayside_shrine" />
			<text key="name" text="Name" />
			<text key="inscription" text="Inscription" />
			<text key="start_date" text="Erection/sacrification date" />
			<combo key="denomination" text="Denomination" values="roman_catholic,orthodox" />
			<combo key="amenity" text="Amenity" values="no,place of worship" />
			<combo key="tourism" text="Tourism" values="no,attraction" />
			<check key="ruins" text="Ruins" default="off" />
		</item>

[simon04]

According to ​http://taginfo.openstreetmap.org/tags/historic=wayside_shrine#combinations, only 10% of historic=wayside_shrine have religion=christian and only 7% have set building=*.

Before inclusion to JOSM core, the presence of those keys need to be discussed. Note that currently this preset only matches <10% of the existing wayside_shrines.

Presets/Historical_Objects and Presets/BENELUX also include a preset for wayside_shrine.

[anonymous]

Only 10% have religion=christian because people don't know about that tags. I check OSM wiki and this tags are described and accepted. Building can be checkbox.

[simon04]

True, but still, why should we restrict wayside shrines to the Christian religion? We could use a <combo> (maybe with christian as default) instead …
The tag building=wayside_shrine is used 103 times according to ​http://taginfo.openstreetmap.org/tags/building=wayside_shrine, so maybe we should neglect this for now?

[anonymous]

I never see non Christian shrines but maybe exist. Why not new building tag for this? If school have, why not shrine.

[anonymous]

I have people for tag this and they ask me for this preset. Can someone add this?

[simon04]

We just released milestone:14.01 which means that we dod not add new features (esp. new presets) in the week before to finalize translations. And there are still open questions concerning some tags in this preset. –– Rome wasn't built in a day.

[Klumbumbus]

In 8016/josm:

fix #9601 - improve presets for historic=wayside_cross and historic=wayside_shrine