[PATCH][RFC] Show progress on upload validation

[mkoniecz]

example of changeset that validated for so long that I was sure that JOSM crashed: ​http://www.openstreetmap.org/changeset/19515032

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-12-18 02:33:54
Last Changed Author: Don-vip
Revision: 6489
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-12-18 03:03:14 +0100 (Wed, 18 Dec 2013)
Last Changed Rev: 6489

Identification: JOSM/1.5 (6489 en_GB) Windows 7 32-Bit
Memory Usage: 236 MB / 247 MB (112 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (30117)
Plugin: buildings_tools (30057)
Plugin: notes (v0.6)

[GerdP]

I once tried to implement this but got lost. The validation time also depends on the unchanged data. I think I saw this when I changed data near multipolygon for Lake Huron. If the multipolygon is completely downloaded it takes quite long.

[gaben]

I looked into the internals. I saw a few fixmes around the upload hooks and once the missing progress monitor was also mentioned. Probably the five classes which implement the UploadHook interface need to be subclassed from PleaseWaitRunnable.

[taylor.smock]

Add checkPreUploadConditionsAsync, use ValidationTask in more locations

[gaben]

I cannot check the patch right now, as my local env is messed up with many irrelevant changes, but I intend this comment as a ping.

[gaben]

minor documentation and import fixes, functionally the same

[gaben]

I just did a quick sanity check and the validation works.

The attached patch contains only minor fixes (like moving from recently replaced javax to jakarta) and documentation formatting compared to @talyor.smock's version.

[taylor.smock]

Thanks for poking this. I'll double check, but I can probably apply it sometime this week.

like moving from recently replaced javax to jakarta

Thanks for doing this. We are still bundling the javax versions of the JSON parsing libraries since plugins depend upon it. I'll be updating JOSM maintained plugins starting in July.

[taylor.smock]

In 18752/josm:

Fix #9446: Show progress on upload validation (patch updated by gaben)

This does the following:

• Use ValidationTask in more locations (ValidatorCLI and ValidateUploadHook specifically)
• Add an async method for checking upload conditions

[GerdP]

see #23522 for a possible regression