#9405 closed defect (fixed)
Problem with validator for "highway=incline_steep"
| Reported by: | naoliv | Owned by: | team |
|---|---|---|---|
| Priority: | minor | Milestone: | 13.12 |
| Component: | Core validator | Version: | |
| Keywords: | template_report | Cc: |
Description
I was validating some data and saw a warning about the outdated usage of "highway=incline_steep".
Clicked to fix it and saw the nodes that were (wrongly?) tagged with only highway=incline_steep being transformed into highway=road + incline=up (it's wrong to have a node tagged with highway=road)
Since basically all the highway=incline_steep are tagged on nodes (http://taginfo.openstreetmap.org/tags/highway=incline_steep), shouldn't the fix be another one? Only give a warning (whithout an automatic fix), discard or some better fix?
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2013-12-07 03:32:55 Last Changed Author: Don-vip Revision: 6449 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2013-12-07 04:29:28 +0100 (Sat, 07 Dec 2013) Last Changed Rev: 6449 Identification: JOSM/1.5 (6449 pt_BR) Linux Debian GNU/Linux unstable (sid) Memory Usage: 405 MB / 1756 MB (191 MB allocated, but free) Java version: 1.7.0_25, Oracle Corporation, OpenJDK 64-Bit Server VM Java package: openjdk-7-jre:amd64-7u25-2.3.12-4 VM arguments: [-Djava.net.useSystemProxies=true, -Dawt.useSystemAAFontSettings=on, -Dawt.useSystemAAFontSettings=on] Dataset consistency test: No problems found Plugin: AddrInterpolation (30034) Plugin: Create_grid_of_ways (29854) Plugin: ImageryCache (29946) Plugin: OpeningHoursEditor (29854) Plugin: PicLayer (29854) Plugin: SimplifyArea (30017) Plugin: buildings_tools (30057) Plugin: editgpx (29854) Plugin: geotools (29767) Plugin: jts (29854) Plugin: merge-overlap (30034) Plugin: notes (v0.7) Plugin: opendata (30097) Plugin: pdfimport (29913) Plugin: reverter (30031) Plugin: tagging-preset-tester (30017) Plugin: turnrestrictions (30110) Plugin: undelete (29854) Plugin: utilsplugin2 (30017)
Attachments (0)
Change History (8)
comment:1 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
follow-up: 4 comment:2 by , 11 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
It's almost fixed I think.
From http://wiki.openstreetmap.org/wiki/Incline we can see:
On nodes The use of this tag has limited (if any) usage, as nodes do not have a direction.
Does it make sense to fix this problem by making them "incline=up"? Shouldn't JOSM give only a warning about this issue (so the user could properly tag the way) instead automatically fixing it?
follow-up: 7 comment:3 by , 11 years ago
I don't understand what exactly people wanted to map with the old tag on nodes ?
comment:4 by , 11 years ago
Replying to naoliv@…:
Does it make sense to fix this problem by making them "incline=up"? Shouldn't JOSM give only a warning about this issue (so the user could properly tag the way) instead automatically fixing it?
+1
comment:6 by , 11 years ago
| Milestone: | → 13.12 (6502) |
|---|
comment:7 by , 11 years ago
Replying to Don-vip:
I don't understand what exactly people wanted to map with the old tag on nodes ?
"Here's a (short'ish) unexpectedly steep incline, some e.g. cyclists or lorry drivers may wish to avoid it." Current tags are more descriptive, but that was a reasonable first step. Some paper maps used to have symbols for such, too.
In 6459/josm: