[patch] Allow align in circle for multiple ways

[anonymous]

The current implementation of align in circle can only be used with nodes oder a single closed way. For ease of use with e.g. roundabouts that are split it would be nice if you could select multiple ways that are joined end-to-end and form a closed loop and align them in a circle as if they were one way.

For comparison, the rectify action is already possible on multiple ways.
It is also already possible to use align in circle on an unclosed way.

[skyper]

Meanwhile you can use "select all way nodes" from utilsplugin2 to select all nodes of the ways.

[Balaitous]

I propose a patch allowing align in circle for multiple ways if there can be joined into a polygon.
See bug9223.patch
Patch created from core directory with svn diff.

[Balaitous]

I propose a new patch: bug9223-v2.patch with some improvement :

Each node with no other referrers than selected ways is placed regularly.

[skyper]

Replying to Balaitous:

I propose a new patch: bug9223-v2.patch with some improvement :

Each node with no other referrers than selected ways is placed regularly.

Did you have in mind that this will not work with incomplete data ?

[Balaitous]

Replying to skyper:

Replying to Balaitous:

I propose a new patch: bug9223-v2.patch with some improvement :

Each node with no other referrers than selected ways is placed regularly.

Did you have in mind that this will not work with incomplete data ?

It's a good question !
But it's already the case for regular polygon. And you can manually change a node position even if data are incomplete.
I think it is better to regularly align point between exits of a roundabout.

[skyper]

Replying to Balaitous:

Replying to skyper:

Replying to Balaitous:

I propose a new patch: bug9223-v2.patch with some improvement :

Each node with no other referrers than selected ways is placed regularly.

Did you have in mind that this will not work with incomplete data ?

It's a good question !
But it's already the case for regular polygon. And you can manually change a node position even if data are incomplete.
I think it is better to regularly align point between exits of a roundabout.

Maybe, at least, a warning about incomplete data would be nice or even deny to perform this action on incomplete data.

[Balaitous]

display a notification if nodes are outside of download area

[Balaitous]

open dialog if nodes are outside of download area

[Balaitous]

I don't think it is very useful. There are no notification when you move a node outside of download area.
But I propose 2 solutions :

• bug9223-v3-simple_notification.patch​: A simple warning notification
• bug9223-v4-dialog.patch​: A dialog, ask confirmation from user

[bastiK]

In 6892/josm:

applied #9223 - Allow align in circle for multiple ways (patch by Balaitous)

[bastiK]

Thanks, works well!

[skyper]

Ticket #6366 has been marked as a duplicate of this ticket.