[patch] add official_name key to presets

[mkoniecz]

makes sense, used ​http://taginfo.openstreetmap.org/keys/?key=official_name#overview and documented on wiki: ​http://wiki.openstreetmap.org/wiki/Key:name

[skyper]

Where is it needed ? In all presets with name=* or only in some ?

What about short_name ? (​taginfo)

[mkoniecz]

In all presets, everywhere there is a risk of obnoxiously long and unused official names. short_name also seems to be OK and usable everywhere where name would be used.

[skyper]

Replying to Bulwersator:

In all presets, everywhere there is a risk of obnoxiously long and unused official names. short_name also seems to be OK and usable everywhere where name would be used.

This would blow up the preset. Looking at the combinations the tags are used with highway, amenity and place.

I really look forward to have grouping within preset syntax and some system to hide/unhide or even link to other preset.

Only looking at *name* we have:

1. name
2. name:[LC]
3. ​int_name
4. ​old_name
5. ​official_name
6. ​loc_name
7. ​reg_name
8. ​short_name
9. ​nat_name

Think the best we for now would be an new preset item name with all the variants and match=key set.

[skyper]

I would suggest to create an own "name" preset with all the variants which could be link in future from every other preset and which have a link from tag dialog once *name* exists.

Does the function for LC in addr:country also work for name:LC , guess not ?
A variable tag seems not to be supported so far.

[skyper]

patch

[skyper]

Please find attached draft patch​ which adds all the above mentioned names except of the language code example plus adds a lot of wiki links and removes roof from "residential buildings".

• Did not solve the language code problem
• an icon is missing so far

[skyper]

icon from www.wowwiki.com/File:Icon-font.svg (License CC-BY-SA)

[skyper]

patch version 2

[skyper]

I did find an icon and update the patch.

Think it can be applied as including name:<lc> is out of scope and needs deeper changes/enhancements.

Please find version 2​.

[simon04]

Some thoughts:

• is line 6884, <label text="Edit Garages" /> intended?
• the "Name" presets is then displayed in the tag togging dialog for every objects with a name set. Do we want this? Alternatively, we could display this preset only if an additional *_name is set (using the match attribute in the XML).

[skyper]

Replying to simon04:

Some thoughts:

• is line 6884, <label text="Edit Garages" /> intended?

Surely not, thanks for mentioning.

• the "Name" presets is then displayed in the tag togging dialog for every objects with a name set. Do we want this? Alternatively, we could display this preset only if an additional *_name is set (using the match attribute in the XML).

It would be much nicer, if we had e.g. folding to hide/unhide parts of preset. I did not want to add these lines to all preset containing name, that's the reason I did use the matching. Once name is added you will have the link to add more names. If you drop the match from name the new preset probably won't be noticed by a lot of users.

[simon04]

I guess, in 90% of the time you won't need an additional *_name, e.g., most of the streets, shops, etc., only have one name. Thus, I wouldn't list the "Name" preset in those cases, but only if a special *_name is set.

[skyper]

patch version 3

[skyper]

Replying to simon04:

I guess, in 90% of the time you won't need an additional *_name, e.g., most of the streets, shops, etc., only have one name. Thus, I wouldn't list the "Name" preset in those cases, but only if a special *_name is set.

Best would be to have #8959 implemented that I could add a link next to name on every preset to have this extra preset opened. That is why I did first add the "match" but you are right, it was a bad hack.

Please, find attached version 3​, which fixes the two issues mentioned above.

[Don-vip]

In 6464/josm:

fix #9166 - new *name preset + add missing links (patch by skyper)

[skyper]

@Don-vip:
You forgot to add the icon !

[simon04]

How to correctly attribute the icon (CC-BY-SA)? Or should we use e.g. ​http://thenounproject.com/term/comment/17394/ instead which is licensed public domain?

[simon04]

In 6470/josm:

fix #9166 - add icon to *name preset

Icon is taken from ​http://thenounproject.com/term/comment/17394/ (public domain).

[skyper]

Replying to simon04:

How to correctly attribute the icon (CC-BY-SA)? Or should we use e.g. ​http://thenounproject.com/term/comment/17394/ instead which is licensed public domain?

I am not that familiar with the legal situation but we could simply link to the icon and not include it.

I was looking for a SVG and not for a PNG otherwise I would have had plenty options (this is also true for the power icons). Gonna try to look, once more, through the icons included in debian to find an appropriate one.

Actually, I do not like this icon as it looks more like an icon for "description" or "note" but not for "name".

[Don-vip]

Maybe we can find a better one, but I didn't like the other one neither.

[skyper]

Replying to Don-vip:

Maybe we can find a better one, but I didn't like the other one neither.

Ok, next time just comment, please.

What kind of icon do you have in mind ? More like an icon for fonts selection ?

It is not that easy to find an icon which scops with "name".

[Don-vip]

Replying to skyper:

Ok, next time just comment, please.

The missing icon was not intentional I just didn't see it, sorry. Just to say I prefer simon's one, but I agree it is not perfect, there's surely another one :) Otr if it's too difficult to find a good one, we can also have no icon, I don't see this as a problem if the concept cannot be easily illustrated. It's better than a confusing icon.

[stoecker]

Milestone renamed