[PATCH] add more values for historic=*

[mkoniecz]

​tags/historic=church is not really popular (barely over 1000 in existence), but historic key is already in presets and church tag makes sense, and AFAIK there is no better alternative for historic churches (both in presets and among more popular tags).

[skyper]

There exists an external presets for historic objects.

[skyper]

Maybe, we can get the auther(s) of the external preset to submit a patch for the internal preset. There are quite some duplicate entries ATM and at least the entries which are already in the internal preset could be updated/expended in favour of the duplicat entries in the external preset.

[skyper]

While ​fort is in defaultpresets some values with higher number and wiki pages are missing:

1. ​charcoal_pile
2. ​citywalls
3. ​heritage
4. ​mine_shaft
5. ​shieling
6. ​mine
7. ​manor
8. ​milestone
9. ​church
10. ​city_gate

[hiddewie]

Usage of all those other historic tags: ​https://taghistory.raifer.tech/#***/historic/church&***/historic/city_gate&***/historic/manor&***/historic/church&***/historic/charcoal_pile&***/historic/mine&***/historic/mine_shaft&***/historic/shieling&***/historic/city_gate&***/historic/milestone&***/historic/milestone

[hiddewie]

Patch added for all historic items with enough tag usage.

Icons:

• charcoal_pile has no icon
• citywalls same visualization as barrier = city_wall
• mine & mine_shaft have same icon (existing mine icon)
• shieling has no icon
• manor has OSM icon ​https://wiki.openstreetmap.org/wiki/File:Manor-14.svg
• milestone has self created adapted boundary_stone icon
• church has existing church icon
• city_gate has OSM icon ​https://wiki.openstreetmap.org/wiki/File:City-gate-14.svg

[Klumbumbus]

Every new item needs an own icon and not share an icon with another item thats confusing.

[Klumbumbus]

Also the milestone icon doesn't work within JOSM.

[hiddewie]

I have fixed some of the icons. Also they have been deduplicated from their non-historic counterparts.

The mine and mineshaft (historic) still use the same icon, just like mine and mineshaft (non-historic) use the same icon.

[Klumbumbus]

Thx. The milestone icon still doesn't work well within JOSM though.

[hiddewie]

OK that is strange. I took the milestone SVG from nodist, which does work well.

[hiddewie]

with milestone from nodist

[Klumbumbus]

In 16748/josm:

fix #9164 - Add more historic presets (patch by hiddewie, modified)

• historic=citywalls (internal icon reused)
• historic=city_gate (icon ​https://wiki.openstreetmap.org/wiki/File%3ACity-gate-14.svg, color changed, PD and CC0 licensed)
• historic=manor (icon from ​https://wiki.openstreetmap.org/wiki/File:Manor-14.svg, PD and CC0 licensed)
• historic=church (icon derived from internal icon, PD and CC0 licensed)
• historic=charcoal_pile (icon derived from internal icon, PD and CC0 licensed)
• historic=mine (icon derived from internal icon, PD and CC0 licensed)
• historic=mine_shaft (icon derived from internal icon, PD and CC0 licensed)
• historic=shieling (icon derived from internal icon, PD and CC0 licensed)
• historic=milestone (icon self created, PD and CC0 licensed)

[Klumbumbus]

I created a new milestone icon because we used that icon from nodist for railway=milestone or highway=milestone in the past and that might be confusing. I changed the historic mine icon, flipped it. I saw this on printed maps for disused mines.

What are the icon sources of church, charcoal_pile, mine and shieling? Or which did you create yourself?

[hiddewie]

Perfect, thanks.

Church, charcoal_pile, mine + mine_shaft and shieling are all modified icons from the JOSM code base, so under the same license.

[Klumbumbus]

Thx.

[Klumbumbus]

Some icons do not work. Under investigation...

[Klumbumbus]

In 16753/josm:

see #9164 - fix icon display

[Klumbumbus]

In 16754/josm:

fix #9164 - fix icon display for real

[Klumbumbus]

That was tricky ;)

[gaben]

Replying to Klumbumbus:

I changed the historic mine icon, flipped it.

:D