#9156 closed defect (fixed)
[patch] Colours livingdashed and raildashed can't be translated
Reported by: | AlfonZ | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | 13.11 |
Component: | Core | Version: | |
Keywords: | i18n | Cc: | stoecker |
Description
Named dashed colours livingdashed and raildashed are specified in elemstyles.xml at L501 and L968, but are currently not extracted for translation. Attached patch fixes it.
Includes a patch for improved descriptions of colours - it lists their usage based on tags specified in rule's conditions.
Examples:
#. color green
becomes
#. color green (applied for "landuse=farm") #. color green (applied for "landuse=farmland") #. color green (applied for "landuse=meadow") #. color green (applied for "landuse=vineyard") #. color green (applied for "landuse=orchard") #. color green (applied for "landuse=allotments") #. color green (applied for "landuse=greenhouse_horticulture") #. color green (applied for "landuse=grass") #. color green (applied for "landuse=village_green") #. color green (applied for "landuse=recreation_ground") #. color green (applied for "natural=grassland")
#. color marsh
becomes #. color marsh (applied for "natural=wetland")
Attachments (1)
Change History (7)
by , 11 years ago
Attachment: | 9156.patch added |
---|
comment:1 by , 11 years ago
Cc: | added |
---|
comment:2 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
follow-up: 4 comment:3 by , 11 years ago
Thanks, this is a great improvement and helps translations!
I have spotted some possible overlaps. Are these colors correct?
(yard, spur)
#. color raildashed (applied for "railway=rail")
#. color raildashed (applied for "railway=rail, service=siding")
#. color raildashed (applied for "railway=rail, service=yard")
#. color raildashed (applied for "railway=rail, service=spur")
#: build/trans_style.java:968 build/trans_style.java:975
#: build/trans_style.java:982 build/trans_style.java:989
msgid "raildashed"
#. color railyard (applied for "railway=rail, service=yard")
#. color railyard (applied for "railway=rail, service=spur")
#: build/trans_style.java:982 build/trans_style.java:989
msgid "railyard"
(tram)
#. color otherrail (applied for "railway=tram")
#. color otherrail (applied for "railway=light_rail")
#: build/trans_style.java:996 build/trans_style.java:1003
msgid "otherrail"
#. color railover (applied for "railway=tram")
#: build/trans_style.java:997
msgid "railover"
comment:4 by , 11 years ago
Replying to aceman:
I have spotted some possible overlaps. Are these colors correct?
They are.
(yard, spur)
Rails are drawn with dashed lines, both of these colors can be customized. rail
, railyard
are the main ones (darker), raildashed
is the complementary one (lighter).
(tram)
Tram's otherrail
is used when the tram is alone (i.e. no highway=*
on the same way), railover
is used in joined case (tram and some other highway; highway takes the main color, tram will be drawn as dashes on top of it).
comment:5 by , 11 years ago
Milestone: | → 13.11 (6383) |
---|
Fixed in [o29999]. Thanks !