Opened 11 years ago
Last modified 5 years ago
#9125 reopened enhancement
shop=ice_cream should be detected and fixed to amenity=ice_cream
Reported by: | mkoniecz | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | |
Keywords: | Cc: |
Description
Attachments (0)
Change History (14)
comment:2 by , 11 years ago
Note that shop=ice_cream is not recognised by JSOM and amenity=ice_cream is, this move is recommended both by wiki and taginfo. Statistics are around 3300 to 600.
But I was also surprised that it is moved in this direction. Adding recognition of shop=ice_cream would also be good for me.
comment:3 by , 11 years ago
There was some discussion on tagging@osm a year or two ago which did not end in a conclusion but it was rather about cuisine=ice_cream or amenity=ice_cream. In my opinion we should use shop instead of amenity or amenity=cafe + cuisine=ice_cream.
comment:4 by , 11 years ago
Then - is it possible to add shop = ice_cream to presets and recognise it with an icon?
comment:6 by , 11 years ago
From the very unclear situation for amenity=ice_cream
and shop=ice_cream
and cuisine=ice_cream
it's hard to define a good validator/preset/style.
comment:8 by , 9 years ago
Resolution: | fixed → wontfix |
---|
The tagging situation is still not absolutely clear.
amenity=cafe
+ cuisine=ice_cream
seems to be the most popular variant. This is already suported in JOSM preset.
I just added preset for amenity=ice_cream
(mappaint was already there), which has also a high usage number.
A validator fix to change shop=ice_cream
is not possible atm, as the wiki defines fine differences between them (however I think reality is different). It is also not deprecated in the wiki. OSM carto renderes both, shop=ice_cream
and amenity=ice_cream
.
However I added shop=ice_cream
to ignore list, so it will no longer display the "value not in presets warning".
follow-up: 10 comment:9 by , 5 years ago
A validator fix to change shop=ice_cream is not possible atm, as the wiki defines fine differences between them (however I think reality is different).
I edited wiki and started thread at tagging mailing list. My goal is to remove claims from OSM Wiki that amenity=ice_cream and shop=ice_cream have different meaning, as it is not matching real tagging.
comment:10 by , 5 years ago
Replying to mkoniecz:
started thread at tagging mailing list.
OK, please let us know about the result.
comment:11 by , 5 years ago
There were claims about some abstract differences but claims seemed unconvincing to me.
comment:12 by , 5 years ago
https://github.com/gravitystorm/openstreetmap-carto/issues/3970 proposed to remove rendering for shop=ice_cream
in the default map style (if you think that reason for wontfixing this issue still holds then you probably want to comment there)
comment:13 by , 5 years ago
Also, note https://user-images.githubusercontent.com/42757252/68587144-af0ca300-04c9-11ea-990c-3cd3b9ee65fd.png - currently amenity=ice_cream
is used far more often among mappers than shop=ice_cream
comment:14 by , 5 years ago
Resolution: | wontfix |
---|---|
Status: | closed → reopened |
Sounds strange to me, to move a "shop" tag to the overfull generic "amenity". I doubt that is correct.