#9039 closed enhancement (fixed)
[patch] add support for shop=gift, shop=car_parts, shop=beauty
| Reported by: | aceman | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 13.11 |
| Component: | Internal preset | Version: | latest |
| Keywords: | beauty car_parts gift | Cc: |
Description (last modified by )
Add support for shop=gift, shop=car_parts, shop=beauty, make them be matched by a preset and use some icon to indicate they are known types.
All of them thousands of uses:
http://wiki.openstreetmap.org/wiki/Tag:shop%3Dgift
http://wiki.openstreetmap.org/wiki/Tag:shop%3Dcar_parts
http://wiki.openstreetmap.org/wiki/Tag:shop%3Dbeauty
Attachments (3)
Change History (21)
comment:1 by , 11 years ago
comment:2 by , 11 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | beaty car_parts gift added |
| Priority: | minor → normal |
| Summary: | add support for shop=gifts, shop=car_parts, shop=beauty → add support for shop=gift, shop=car_parts, shop=beauty |
comment:4 by , 11 years ago
| Owner: | changed from to |
|---|
Can anyone suggest some icons (if possible .svg), please ?
comment:5 by , 11 years ago
| Owner: | changed from to |
|---|---|
| Summary: | add support for shop=gift, shop=car_parts, shop=beauty → [patch] add support for shop=gift, shop=car_parts, shop=beauty |
Find attached patch which introduces the three new items plus small fixes and updates.
Did only find an icon for "gift" so far. (openclipart)
At least an icon for "beauty" is missing.
comment:6 by , 11 years ago
follow-up: 8 comment:7 by , 11 years ago
Looks good to me. Only that I don't see "beauty:type" key being used anywhere. Where did you get it from? According to taginfo people stick the type under a "beauty" key for now...
comment:8 by , 11 years ago
Replying to aceman:
Looks good to me. Only that I don't see "beauty:type" key being used anywhere. Where did you get it from? According to taginfo people stick the type under a "beauty" key for now...
Oh sure, I forgot to mention. Thanks for reminding.
I am not sure about "beauty=*" as it does not seem to be a good tag as it might be misleading, especially thinking about translation and if taken out of context.
On the other hand we could even deprecate shop=hairdresser now and move it under shop=beauty.
follow-up: 10 comment:9 by , 11 years ago
So does it mean you invent the beauty:type key here?
Shop=hairdresser is used 55000 times (about 10 times more than "beauty") and is the fifth most popular value of "shop". I don't think we should deprecate it right now and the wiki also does not indicate any decision on deprecating it. Please don't do it.
comment:10 by , 11 years ago
Replying to aceman:
So does it mean you invent the beauty:type key here?
Yes, but ok I can remove it.
The more I look at the issue the more I fear, we need better documentation first. Is it a shop for beauty services like manicure, make-up etc. or is it a shop where you get beauty products. When to use special tags like shop=hairdresser, shop=massage, shop=drugstore, shop=barber, shop=solarium. Overall is this really a shop or a leisure ?
At least useful values for beauty=* are needed.
Shop=hairdresser is used 55000 times (about 10 times more than "beauty") and is the fifth most popular value of "shop". I don't think we should deprecate it right now and the wiki also does not indicate any decision on deprecating it. Please don't do it.
Was just a thought without intension to change for now.
Best for now is to divide the patch and move the beauty part to #8397.
by , 11 years ago
| Attachment: | josm_9039_gift+car_parts.diff added |
|---|
patch for gift + car_parts + fixes
comment:11 by , 11 years ago
comment:13 by , 11 years ago
| Keywords: | beauty added; beaty removed |
|---|
comment:17 by , 11 years ago
| Milestone: | → 13.11 (6383) |
|---|
Sorry, the proper spelling seems to be shop=gift.