Modify

Opened 11 years ago

Closed 11 years ago

#9000 closed enhancement (fixed)

add a preset for entrance=*

Reported by: aceman Owned by: team
Priority: normal Milestone:
Component: Internal preset Version: tested
Keywords: Cc:

Description

Please add a preset for entrance=* , offer the common values and an optional "access" key. http://wiki.openstreetmap.org/wiki/Key:entrance

Then, make it clear in the labels what is the difference from the existing <key key="barrier" value="entrance" />

The icons for entrance=* should already be in place according to other reports.

Attachments (0)

Change History (11)

comment:1 by Don-vip, 11 years ago

Resolution: fixed
Status: newclosed

In 6176/josm:

fix #9000 - add entrance to presets + deprecate building=entrance in favor of it. Icons and map style already ok.

comment:2 by Don-vip, 11 years ago

In 6177/josm:

see #9000 - wrong copy/paste

comment:3 by skyper, 11 years ago

Thanks, Don-vip. Was already thinking about it, too.

I do not like the words in backets, though. We still have barrier=entrance for those gaps in a barrier. Have a look at the discussion on tagging@osm.

comment:4 by Don-vip, 11 years ago

I was not sure about what to do. Leaving just "entrance" may be confusing, do you have another idea ?

in reply to:  4 comment:5 by skyper, 11 years ago

Replying to Don-vip:

I was not sure about what to do. Leaving just "entrance" may be confusing, do you have another idea ?

What about entrance (building/amenity) or similar. For sure it is an opening but I did not find many entrances without barrier so far (usually a door or gate).

comment:6 by aceman, 11 years ago

The patch looks good, thanks. Yes, "entrance (building/amenity)" would be good for disambiguation. Somehow the barrier key does not have any value for a door into a building. It has only values for outdoor barriers/gates.

skyper, what combinations have you seen? barrier=gate+entrance=yes ?

comment:7 by Don-vip, 11 years ago

Resolution: fixed
Status: closedreopened

comment:8 by Don-vip, 11 years ago

I'm not sure this wording is so good for disambiguation. Building entrances should be tagged with entrance key, I find it more confusing.

Maybe switch back to "Entrance" for both and add a validator test to restrict barrier=entrance on nodes on barrier ways ?

Or is there a talk about deprecating barrier=entrance ? I can't see why it couldn't be replaced by entrance=yes, like building=entrance

in reply to:  6 comment:9 by skyper, 11 years ago

Replying to aceman:

skyper, what combinations have you seen? barrier=gate+entrance=yes ?

  • barrier=gate
  • lift_gate
  • barrier=door
  • barrier=turnstile

Replying to Don-vip:

I'm not sure this wording is so good for disambiguation. Building entrances should be tagged with entrance key, I find it more confusing.

Ok, I get it and changed my mind. Your wording should be fine.

Maybe switch back to "Entrance" for both and add a validator test to restrict barrier=entrance on nodes on barrier ways ?

+1, for the test

Or is there a talk about deprecating barrier=entrance ? I can't see why it couldn't be replaced by entrance=yes, like building=entrance

Not so far and there are small but important differences !

  1. I do not expect a barrier at barrier=entrance
  2. I do not expect a limited height at barrier=entrance

comment:10 by aceman, 11 years ago

From the image on the wiki, a barrier=entrance is a hole in a barrier (wall/fence). entrance=* on a building actually may have a barrier (e.g. a door) that is not passable when mounted on a bike.

comment:11 by Don-vip, 11 years ago

Resolution: fixed
Status: reopenedclosed

In 6192/josm:

fix #9000 - add a new validator test on barrier=entrance not set on a barrier

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.