plugins list wiki page fails to detect updates

[anonymous]

What steps will reproduce the problem?

1. sele with slippy map area
2. try to load
3. get this error

What is the expected result?
load and show

What happens instead?
error bug report
layer created in layers list
no data downloaded

Please provide any additional information below. Attach a screenshot if
possible.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-08-22 01:35:25
Last Changed Author: Don-vip
Revision: 6174
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-08-22 01:23:38 +0200 (Thu, 22 Aug 2013)
Last Changed Rev: 6174

Identification: JOSM/1.5 (6174 it) Linux Ubuntu 13.04
Memory Usage: 186 MB / 419 MB (92 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, Java HotSpot(TM) Server VM

Plugin: AddrInterpolation (29854)
Plugin: FastDraw (29854)
Plugin: ImportImagePlugin (29854)
Plugin: OpeningHoursEditor (29854)
Plugin: PicLayer (29854)
Plugin: SimplifyArea (29854)
Plugin: buildings_tools (29854)
Plugin: continuosDownload (28565)
Plugin: dataimport (29854)
Plugin: download_along (29854)
Plugin: geochat (29851)
Plugin: geotools (29767)
Plugin: irsrectify (29210)
Plugin: jts (29854)
Plugin: log4j (29853)
Plugin: mapdust (29854)
Plugin: mirrored_download (29854)
Plugin: namemanager (29854)
Plugin: notes (cb146cc)
Plugin: opendata (29854)
Plugin: openstreetbugs (29854)
Plugin: print (29854)
Plugin: proj4j (29854)
Plugin: reverter (29854)
Plugin: scripting (30540)
Plugin: tageditor (29854)
Plugin: tagging-preset-tester (29854)
Plugin: terracer (29854)
Plugin: turnrestrictions (29854)
Plugin: undelete (29854)
Plugin: utilsplugin2 (29854)
Plugin: walkingpapers (29854)
Plugin: waydownloader (29854)
Plugin: wayselector (29854)
Plugin: wikipedia (29854)

java.lang.reflect.InvocationTargetException
	at java.awt.EventQueue.invokeAndWait(EventQueue.java:1272)
	at java.awt.EventQueue.invokeAndWait(EventQueue.java:1247)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:87)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:150)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
	at java.util.concurrent.FutureTask.run(FutureTask.java:166)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:724)
Caused by: java.lang.VerifyError: (class: org/openstreetmap/josm/plugins/notes/NotesDownloadLoop, method: run signature: ()V) Incompatible object argument for function call
	at org.openstreetmap.josm.plugins.notes.NotesPlugin.layerAdded(NotesPlugin.java:219)
	at org.openstreetmap.josm.gui.MapView.fireLayerAdded(MapView.java:175)
	at org.openstreetmap.josm.gui.MapView.addLayer(MapView.java:350)
	at org.openstreetmap.josm.Main.addLayer(Main.java:452)
	at org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask$DownloadTask.finish(DownloadOsmTask.java:282)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable$1.run(PleaseWaitRunnable.java:90)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:241)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:733)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:694)
	at java.awt.EventQueue$3.run(EventQueue.java:692)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:703)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:154)
	at java.awt.WaitDispatchSupport$2.run(WaitDispatchSupport.java:182)
	at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:221)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.awt.WaitDispatchSupport.enter(WaitDispatchSupport.java:219)
	at java.awt.Dialog.show(Dialog.java:1082)
	at java.awt.Component.show(Component.java:1651)
	at java.awt.Component.setVisible(Component.java:1603)
	at java.awt.Window.setVisible(Window.java:1014)
	at java.awt.Dialog.setVisible(Dialog.java:1005)
	at org.openstreetmap.josm.gui.progress.PleaseWaitProgressMonitor$4.run(PleaseWaitProgressMonitor.java:172)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:733)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:694)
	at java.awt.EventQueue$3.run(EventQueue.java:692)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:703)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

[Don-vip]

Problem of external plugins we cannot update after core changes.The plugin must be recompiled for josm r6162 see #8987

[iandees]

Upgrade your notes plugin. The "NotesDownloadLoop" doesn't exist anymore.

[AlfonZ]

Ticket #9026 has been marked as a duplicate of this ticket.

[scai]

Same problem here. The notes plugin is up-to-date according to JOSM and can't be updated. JOSM version 6208 (=latest), notes plugin version cb146cc

[AlfonZ]

Replying to scai:

Same problem here. The notes plugin is up-to-date according to JOSM and can't be updated. JOSM version 6208 (=latest), notes plugin version cb146cc

Hmm, I have the latest version (v0.5) and JOSM always tries to update is anyway - similar to #2120.
It seems to be caused by not updated plugin overview - it shows version cb146cc, date 2013-07-22 22:05:13 -0500, while the latest jar's manifest says v0.5 and 2013-08-24 14:44:20 -0500.
Other affected plugins seem to be fieldpapers and TombPlugin (external as well).

Also, my notes's version in Help/About/Plugins says cb146cc, version in Help/Show Status Report is v0.5.

[iandees]

​cb146cc is from July. I suggest removing the plugin, restarting JOSM, and then adding it again.

[scai]

I deleted ~/.josm/plugins/notes.jar and downloaded the plugin again. JOSM still displays it as version cb146cc (v0.5) but it works. I don't get it. Maybe the file has been updated but the internal version not? That would also explain why it wouldn't want to update the plugin in the first place.

[skyper]

Replying to AlfonZ:

Replying to scai:

Same problem here. The notes plugin is up-to-date according to JOSM and can't be updated. JOSM version 6208 (=latest), notes plugin version cb146cc

Hmm, I have the latest version (v0.5) and JOSM always tries to update is anyway - similar to #2120.

Yeah, the plugin is downloaded every time a new latest (JOSM version) is started (default plugin policy).

[scai]

So there is still something wrong. Based on which information is the plugin overview generated?

[Don-vip]

Ticket #9041 has been marked as a duplicate of this ticket.

[Don-vip]

It seems there's a problem with the server's code that manages plugin list when external plugins change their URL. It's a very recent thing that only happens with recent github plugins. Dirk, do you have any immediate idea on what needs to be fixed ?

[stoecker]

@notes developers:

The call wget --no-check-certificate --timeout=10 -t 2 -N "https://github.com/iandees/josm-notes/releases/download/v0.5/notes.jar" results in a 403 error. Thus downloads of new plugin version fail. Removing "-N" is not a good idea either. You should find another place than github to store these files. Github has to many restrictions to be really usable for file dissemination:

• changing filenames
• redirects
• no timestamping

Why don't you simply use the OSM-SVN? All these troubles result only from GitHub usage.

[Don-vip]

Replying to stoecker:

The call wget --no-check-certificate --timeout=10 -t 2 -N "https://github.com/iandees/josm-notes/releases/download/v0.5/notes.jar" results in a 403 error.

I just have contacted Github support to know if it's normal behaviour or a bug.

[Don-vip]

I received a response from Github, they told me the command works. Indeed I tried and all seems OK:

wget --no-check-certificate --timeout=10 -t 2 -N "https://github.com/iandees/josm-notes/releases/download/v0.5/notes.jar"
--2013-09-06 01:49:34--  https://github.com/iandees/josm-notes/releases/download/v0.5/notes.jar
Resolving github.com (github.com)... 192.30.252.131
Connecting to github.com (github.com)|192.30.252.131|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://s3.amazonaws.com/github-cloud/releases/11394163/c30dfff6-0cf6-11e3-97fb-46dccc034232.jar?response-content-disposition=attachment%3B%20filename%3Dnotes.jar&AWSAccessKeyId=AKIAISTNZFOVBIJMK3TQ&Expires=1378425034&Signature=w9XOralqtJQ%2Bt3%2BsY08eUvOdl%2BE%3D [following]
--2013-09-06 01:49:34--  https://s3.amazonaws.com/github-cloud/releases/11394163/c30dfff6-0cf6-11e3-97fb-46dccc034232.jar?response-content-disposition=attachment%3B%20filename%3Dnotes.jar&AWSAccessKeyId=AKIAISTNZFOVBIJMK3TQ&Expires=1378425034&Signature=w9XOralqtJQ%2Bt3%2BsY08eUvOdl%2BE%3D
Resolving s3.amazonaws.com (s3.amazonaws.com)... 72.21.215.132
Connecting to s3.amazonaws.com (s3.amazonaws.com)|72.21.215.132|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 434516 (424K) [application/octet-stream]
Saving to: `notes.jar'

100%[===================================================================================================================>] 434,516      469K/s   in 0.9s

2013-09-06 01:49:36 (469 KB/s) - `notes.jar' saved [434516/434516]

[stoecker]

Sorry, I forgot to add: On a fresh system you need to call it twice. Otherwise "-N" has no effect!

[AlfonZ]

​todo plugin uses committed download instead of Releases.
wget --no-check-certificate --timeout=10 -t 2 -N "https://raw.github.com/Gnonthgol/JOSM-todo/master/dist/todo.jar" works even with existing file, but there are no timestamps supplied and the file gets always downloaded.

[Don-vip]

Replying to stoecker:

Sorry, I forgot to add: On a fresh system you need to call it twice. Otherwise "-N" has no effect!

Ok thanks I replied to Github. I think they forgot to give a required parameter to Amazon AWS. I hope they're going to fix this.

[Don-vip]

Got this response from Github:

You're right, it does look like an S3 issue. This is something I'd like to fix at some point.

Wait'n see :)

[stoecker]

I updated the files on disk, so at least the current state for notes plugin is correct.

[stoecker]

Hah, as a result I lost two other files, where openstreetmap.pl seems to block access from JOSM server :-)

[stoecker]

No, component Trac is wrong. The supplied link is the reason, not our trac.

[iandees]

Replying to stoecker:

No, component Trac is wrong. The supplied link is the reason, not our trac.

No it isn't. The plugin isn't doing anything wrong here.

To solve your update check, why not use curl? It seems to handle this correctly:

First request:

$ curl -s -L -D - -z notes.jar -o notes.jar https://github.com/iandees/josm-notes/releases/download/v0.6/notes.jar
HTTP/1.1 302 Found
Server: GitHub.com
Date: Fri, 27 Sep 2013 12:01:50 GMT
Content-Type: text/html; charset=utf-8
Status: 302 Found
Cache-Control: no-cache
Strict-Transport-Security: max-age=2592000
X-Frame-Options: deny
Location: https://s3.amazonaws.com/github-cloud/releases/11394163/fe179430-271e-11e3-8f3e-6479e1dfb199.jar?response-content-disposition=attachment%3B%20filename%3Dnotes.jar&AWSAccessKeyId=AKIAISTNZFOVBIJMK3TQ&Expires=1380283370&Signature=hFcpRA%2B9O2BilDxwuerj91iL8EM%3D
Set-Cookie: logged_in=no; domain=.github.com; path=/; expires=Tue, 27-Sep-2033 12:01:50 GMT; secure; HttpOnly
Set-Cookie: _gh_sess=BAh7CDoPc2Vzc2lvbl9pZCIlZWY0MGQ5ZTNmYTAwMjI3MmE5Y2M4NDdkYzA2YmZiMTY6DXNweV9yZXBvSSIXaWFuZGVlcy9qb3NtLW5vdGVzBjoGRVQ6EHNweV9yZXBvX2F0SXU6CVRpbWUNbGMcgBA6IQcJOg1uYW5vX251bWkCzgI6DW5hbm9fZGVuaQY6DXN1Ym1pY3JvIgdxgDoLb2Zmc2V0af6QnQ%3D%3D--5684cc16b7bf02931619ef2d209e53f0b34b3061; path=/; secure; HttpOnly
X-Runtime: 7
Content-Length: 338
X-GitHub-Request-Id: 36EAA6C5:124F:94D866F:524573AE
Vary: Accept-Encoding

HTTP/1.1 200 OK
x-amz-id-2: 4AkUKGj4ERpCnaU0YTV7hI8xOMJY6+GiB7PJMm7UcEmw73RN8QhKTi344iTQATjY
x-amz-request-id: 6EBD8F27A2459B7F
Date: Fri, 27 Sep 2013 12:01:51 GMT
x-amz-meta-surrogate-control: max-age=31557600
x-amz-meta-surrogate-key: repository-11394163 user-261584
Cache-Control: max-age=31557600
Content-Disposition: attachment; filename=notes.jar
Last-Modified: Fri, 27 Sep 2013 02:46:23 GMT
ETag: "99fde05852cc8a1ebc9a02ecf39ea615"
Accept-Ranges: bytes
Content-Type: application/octet-stream
Content-Length: 119365
Server: AmazonS3

Second run:

$ curl -s -L -D - -z notes.jar -o notes.jar https://github.com/iandees/josm-notes/releases/download/v0.6/notes.jar
HTTP/1.1 302 Found
Server: GitHub.com
Date: Fri, 27 Sep 2013 12:02:14 GMT
Content-Type: text/html; charset=utf-8
Status: 302 Found
Cache-Control: no-cache
Strict-Transport-Security: max-age=2592000
X-Frame-Options: deny
Location: https://s3.amazonaws.com/github-cloud/releases/11394163/fe179430-271e-11e3-8f3e-6479e1dfb199.jar?response-content-disposition=attachment%3B%20filename%3Dnotes.jar&AWSAccessKeyId=AKIAISTNZFOVBIJMK3TQ&Expires=1380283394&Signature=LXHII7cO%2BJCa5axnClOihOsnDTU%3D
Set-Cookie: logged_in=no; domain=.github.com; path=/; expires=Tue, 27-Sep-2033 12:02:14 GMT; secure; HttpOnly
Set-Cookie: _gh_sess=BAh7CDoPc2Vzc2lvbl9pZCIlMWQ0YmM0OTFkOWE0ZGQ4YTQ0MGU2YTZlMDFhZmQzMTg6DXNweV9yZXBvSSIXaWFuZGVlcy9qb3NtLW5vdGVzBjoGRVQ6EHNweV9yZXBvX2F0SXU6CVRpbWUNbGMcgHa66wgJOg1uYW5vX251bWkCQQI6DW5hbm9fZGVuaQY6DXN1Ym1pY3JvIgdXcDoLb2Zmc2V0af6QnQ%3D%3D--fc1ff8aba0811a1131cafee2f263d07d484649c7; path=/; secure; HttpOnly
X-Runtime: 7
Content-Length: 338
X-GitHub-Request-Id: 36EAA6C5:124F:94DB8D9:524573C6
Vary: Accept-Encoding

HTTP/1.1 304 Not Modified
x-amz-id-2: xaejlRMYzCSlm2uLj144dNmAILYefP5t39KeaEMYuCdexYpcF7DlO9PjasCJ99Tm
x-amz-request-id: CB8D0A7FA9ED12D9
Date: Fri, 27 Sep 2013 12:02:15 GMT
x-amz-meta-surrogate-control: max-age=31557600
x-amz-meta-surrogate-key: repository-11394163 user-261584
Cache-Control: max-age=31557600
Content-Disposition: attachment; filename=notes.jar
Last-Modified: Fri, 27 Sep 2013 02:46:23 GMT
ETag: "99fde05852cc8a1ebc9a02ecf39ea615"
Server: AmazonS3

... it gives you a 304 and doesn't download anything as you would expect.

[iandees]

After poking around a bit it looks like you might be using the wget command here as an example that HEAD requests to the signed S3 URL won't work? This is true: the HEAD request has to be signed differently by GitHub (and thus it will have a slightly different URL than the GET-signed URL) so this won't work.

You should probably be using the If-Modified-Since or If-None-Match headers to check updates. I'm happy to help fix the update code if you can point to where it is.

[stoecker]

Find an replacement of above wget and I will use it. I didn't find the --no-check-certificate for curl.

[iandees]

Here's the equivalent flag in curl:

       -k, --insecure
              (SSL) This option explicitly allows curl to perform "insecure" SSL connections and transfers. All SSL connections are attempted to be  made  secure  by
              using the CA certificate bundle installed by default. This makes all connections considered "insecure" fail unless -k, --insecure is used.

              See this online resource for further details: http://curl.haxx.se/docs/sslcerts.html

[stoecker]

Changed to curl. Should be solved now.

[Don-vip]

Great :) No response from Github concerning my support request, so it's fine if curl works.