[Patch] Preset for Traffic light shows a dialog for Pedestrian crossing

[aceman]

When using Presets->Highways->Waypoints->Traffic signal, the sub-dialog appearing for further details contains attributes for a Pedestrian crossing, e.g. crossing type, crossing type name, cross on horseback, etc.

However, code-wise it is not the same dialog as received from Presets->Highways->Waypoints->Pedestrian crossing. There the labels are bit differently worded, but the meaning is the same.

[skyper]

patch

[skyper]

Find attached patch​ solving this trivial problem.

[aceman]

I can't run with the patch but from just reading it it does not seem to solve the problem.
The updating of texts in <key key="highway" value="crossing" /> seem fine, just fix the introcuded typo in "Pedestrian crossing typ" (should be type). Please add <space /> after the <label> as other dialogs have.

But the traffic signals dialog is unfixed.
Under <key key="highway" value="traffic_signals" /> you need to remove all the current optional elements and add those relevant to a traffic signals, from ​http://wiki.openstreetmap.org/wiki/Traffic_signals. Also please add a <label> and <space>.

[skyper]

Replying to aceman:

Now, I better understand your problem. Find version 2​ attached.

The updating of texts in <key key="highway" value="crossing" /> seem fine, just fix the introcuded typo in "Pedestrian crossing typ" (should be type). Please add <space /> after the <label> as other dialogs have.

fixed.

But the traffic signals dialog is unfixed.
Under <key key="highway" value="traffic_signals" /> you need to remove all the current optional elements and add those relevant to a traffic signals, from ​http://wiki.openstreetmap.org/wiki/Traffic_signals.

Well, taginfo shows different usage (​traffic_signal and ​crossing).

I my opinion, objects which are related to a way inline like traffic_signals, traffic_signs, enforcements and turn_restrictions can not be mapped as a node as they are often direction dependent.

Also please add a <label> and <space>.

I did try to make it more precise with labels.

[skyper]

patch version 2

[aceman]

I have never seen highway=traffic_signals together with crossing=traffic_signals but OK, if the stats say so and people use it...

Then the current patch can be landed, thanks.

[aceman]

Will you please check the patch in?

[Don-vip]

I have trouble to apply it, is it possible to attach a new one against latest revision ? Thanks

[skyper]

unmodified version 3

[skyper]

Replying to Don-vip:

I have trouble to apply it, is it possible to attach a new one against latest revision ? Thanks

Strange, a simple patch did work.

Find updated josm_8973_v3.diff patch​ attached.

[Don-vip]

In 6190/josm:

fix #8973 - presets: allow text attribute on optional item to set custom text + fix traffic_light/pedestrian corssing (modified patch by skyper)