Request note modification permission when setting up oauth

[ToeBee]

The new "Notes" feature on osm.org introduced a new oauth permission. JOSM does not request this permission when setting up oauth tokens. According to a quick grep through the rails port, this permission is identified by the string "allow_write_notes" in the authorization process.

I am attaching a patch that should be a good start on adding this but I think something is missing. It didn't seem to work when doing the fully automatic setup although this is hard to verify because osm.org does not let you view the details of existing oauth configurations. When doing semi-automatic, the "Modify notes" permission is not being listed in the web page that JOSM opens up after step 1. The thought occurred to me that this might be a bug in the rails port although I believe another application has successfully used oauth to edit notes so this seems a little unlikely. I'm not familiar enough with oauth to know exactly what is going on here so I'm hoping someone else can take what I have and figure out whatever is missing.

This is blocking further work on the Notes plugin (#8193).

[ToeBee]

Patch to add the new note permission to the oauth setup process

[ToeBee]

Looks like this will actually take a change by whoever has the consumer key that JOSM uses by default registered on osm.org. Anybody know who that is? Or do we need to get a new one?

[Don-vip]

I'm sure Dirk knows :-)

[stoecker]

Replying to Don-vip:

I'm sure Dirk knows :-)

Why should he? Ah, he's maintainer :-)

No, i have no idea where Gubaer got these values. You could ask the OSM server guys. When you do so, please also tell them to fix the URL for JOSM as well. It should be "​http://josm.openstreetmap.de" and not an non-existing link to oauth in our wiki.

Because JOSM itself does not really need these rights - what about making an "notes" patch to the core instead of a plugin, so it is justified to request such stuff?

[stoecker]

In 6066/josm:

see #8875 - more oauth rights

[ToeBee]

According to Tom, the key currently in use is registered to this user: ​http://www.openstreetmap.org/user/guggis

So either we need to get him to modify it or someone needs to make a new one and then update OAuthParameters.java

Either way, users are going to have to get a new access token before they can use any notes features.

[stoecker]

I created a new user only for JOSM and also created new access. Thought this will kill all old keys. Have to think about a smooth transition.

[stoecker]

In 6067/josm:

see #8875 - add new key (disabled for now) - TODO: should be used as default for any new OAuth request

Any patch for transition welcome. I have holidays...

[stoecker]

In 6076/josm:

fix #8875 - update JOSM key for OAuth, smooth transition for old key.

[stoecker]

Could someone please verify that it works. When an old config file with key is loaded, then preference should from now on contain the old josm key data. As soon as a new OAuth is created it should switch to new one.