Modify

Opened 12 years ago

Closed 11 years ago

#8748 closed enhancement (fixed)

[Patch] add "building=*" to "place of worship"

Reported by: skyper Owned by: team
Priority: minor Milestone:
Component: Internal preset Version:
Keywords: Cc:

Description

It is useful to add building=* to the preset for amenity=place_of_worship.

I attach a patch which adds some values, propably an incomplete list so please add some more if known.

Attachments (2)

josm_8748.patch (2.3 KB ) - added by skyper 12 years ago.
patch
josm_8748_v2.diff (2.3 KB ) - added by skyper 11 years ago.
patch version 2

Download all attachments as: .zip

Change History (10)

by skyper, 12 years ago

Attachment: josm_8748.patch added

patch

comment:1 by Manu1400, 12 years ago

I propose to add too :
building=wayside_chapel is used (see Taginfo);
building=church_hall is used

But building=basilica is not used...

comment:2 by skyper, 12 years ago

Summary: [Patch] add "building=*" to "place of worship"[Draft Patch] add "building=*" to "place of worship"

comment:3 by Don-vip, 12 years ago

skyper, can you provide a new patch by adding used values from taginfo if needed ? thanks

in reply to:  3 comment:4 by skyper, 12 years ago

Replying to Don-vip:

skyper, can you provide a new patch by adding used values from taginfo if needed ? thanks

First I will try to get the payment stuff reworked and use your enhancement. Well, if someone else picks it up meanwhile I am happy, but I will try to find some time for the presets.

Last edited 12 years ago by skyper (previous) (diff)

in reply to:  1 comment:5 by skyper, 12 years ago

Replying to Manu1400:

I propose to add too :
building=wayside_chapel is used (see Taginfo);
building=church_hall is used

The numbers are below 50

But building=basilica is not used...

I can remove it as it is only a special cathedral of the roman-Catholics. "Minster" is also missing but not used so far.

How about other religions ? Do we need more than "temple" and "mosque" ?

comment:6 by skyper, 11 years ago

Find attached patch which simply adds the most common building values.

comment:7 by skyper, 11 years ago

Summary: [Draft Patch] add "building=*" to "place of worship"[Patch] add "building=*" to "place of worship"

by skyper, 11 years ago

Attachment: josm_8748_v2.diff added

patch version 2

comment:8 by Don-vip, 11 years ago

Resolution: fixed
Status: newclosed

In 6188/josm:

fix #8748 - add building=* to amenity=place_of_worship preset

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.