Scripting plugin stealing shortcut for 'properties:edit'.

[rickmastfan67]

Silent shortcut conflict: 'properties:edit' moved by 'menu:Scripting' to 'Ctrl+Alt+F1'.

Just noticed this when seeing if I could duplicate #8667. The Scripting plugin steals the shortcut for the "Edit" button in the properties window.

Steps to reproduce:

1. Have the Scripting plugin installed.
2. Download some data from the OSM server.
3. Notice in the console that the shortcut for 'properties:edit' has been hijacked by the scripting plugin.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-05-02 01:35:17
Last Changed Author: Don-vip
Revision: 5921
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-05-01 03:38:53 +0200 (Wed, 01 May 2013)
Last Changed Rev: 5921

Identification: JOSM/1.5 (5921 en) Windows 7 64-Bit
Memory Usage: 218 MB / 2730 MB (93 MB allocated, but free)
Java version: 1.7.0_21, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Xmx3072M]
Dataset consistency test: No problems found

Plugin: ImageryCache (29484)
Plugin: scripting (30300)

[rickmastfan67]

In response to: ​https://github.com/Gubaer/josm-scripting-plugin/issues/10

Gubaer, the "properties:edit" is a core shortcut, not from another plugin.

I've just tested this with a completely new profile for JOSM and only installed the scripting plugin. Duplicated the "shortcut conflict" the moment I downloaded some data. The "edit" button in the Properties window owns the "Alt+S" shortcut. All other plugins respect this. The Scripting plugin is the only one that doesn't.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-06-09 01:34:50
Last Changed Author: Don-vip
Revision: 5997
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-06-08 14:26:14 +0200 (Sat, 08 Jun 2013)
Last Changed Rev: 5997

Identification: JOSM/1.5 (5997 en) Windows 7 64-Bit
Memory Usage: 154 MB / 2730 MB (74 MB allocated, but free)
Java version: 1.7.0_21, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Xmx3072M]

Plugin: scripting (30510)

[rickmastfan67]

Also, this isn't the first time that this conflict was mentioned. There is a mention of this in ticket:7226#comment:102 as well back during the mass fixing of shortcut conflicts with core/plugins.

[Don-vip]

Fixed in ​https://github.com/Gubaer/josm-scripting-plugin/commit/d4798a434bc105845483331900e2b31a131eac48.