Modify

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#8596 closed enhancement (fixed)

[Patch] "bicycle_road" not in default presets

Reported by: skyper Owned by: team
Priority: minor Milestone:
Component: Internal preset Version: latest
Keywords: bicycle road Cc:

Description (last modified by skyper)

There is no bicycle_road=no/yes in default presets.

I am not sure if it should get an own entry or should be added to some highways or only highway=residential.

Attachments (5)

bicycle_road_sign_icon.svg (5.6 KB ) - added by skyper 12 years ago.
icon: modification of https://de.wikipedia.org/wiki/Datei:Zeichen_244.svg
defaultpresets.xml.bicycle_road.patch (2.4 KB ) - added by skyper 12 years ago.
patch
defaultpresets.xml.bicycle_road_without_check.patch (2.2 KB ) - added by skyper 12 years ago.
Patch without check box in highway=residential dialog
defaultpresets.xml.bicycle_road_final.patch (2.2 KB ) - added by skyper 12 years ago.
final patch
defaultpresets.xml.bicycle_road_final2.patch (2.4 KB ) - added by skyper 12 years ago.
updated patch final version 2

Download all attachments as: .zip

Change History (15)

comment:1 by skyper, 12 years ago

Description: modified (diff)

comment:2 by skyper, 12 years ago

Description: modified (diff)

Does josm support .svgs ?

Do I have to take care of some options (alpha) ?

by skyper, 12 years ago

patch

comment:3 by skyper, 12 years ago

Summary: "bicycle_road" not in default presets[Patch] "bicycle_road" not in default presets

I have attached a patch which includes a new highway entry and a check box for highway=residential.

in reply to:  3 comment:4 by skyper, 12 years ago

Replying to skyper:

I have attached a patch which includes a new highway entry and a check box for highway=residential.

I am not sure about the check box. What do you think about it ?

Anyway, I'll attach a second version without the check box.

by skyper, 12 years ago

Patch without check box in highway=residential dialog

by skyper, 12 years ago

final patch

comment:5 by skyper, 12 years ago

As #8661 was fixed I did some minor rework and attached my final version.

comment:6 by skyper, 12 years ago

Anything wrong with this patch ?

I know the usage is not that high but I want to get it tagged the right way and prevent a mess like living_street.

comment:7 by brycenesbitt, 12 years ago

Getting an English language wiki page up for this is an important step: http://wiki.openstreetmap.org/wiki/Key:bicycle_road is in German as of this reading.

in reply to:  7 comment:8 by skyper, 12 years ago

Replying to brycenesbitt:

Getting an English language wiki page up for this is an important step: http://wiki.openstreetmap.org/wiki/Key:bicycle_road is in German as of this reading.

Done.

Please find attached, updated patch: defaultpresets.xml.bicycle_road_final2.patch

Last edited 12 years ago by skyper (previous) (diff)

by skyper, 12 years ago

updated patch final version 2

comment:9 by Don-vip, 11 years ago

Resolution: fixed
Status: newclosed

In 6159/josm:

fix #8596 - Add bicycle_road to presets (patch by skyper)

comment:10 by skyper, 11 years ago

Thanks

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.