[PATCH] Remove offset server support

[Zverikk]

The osmosnimki server has been down for at least a year, and the API was as bad as it gets. I propose to remove all traces of offset server support, because there isn't going to appear any. Especially with the new imagery offset database infrastructure.

[Zverikk]

A patch to remove all traces of offset server support

[akks]

I vote for the inclusion of the patch (if we are not in stabilization phase at least).

My comments:

New imagery offset database infrastructure is developed by Zverik and it seems to work
​http://wiki.openstreetmap.org/wiki/Imagery_Offset_Database
(but still need testing period, minor updates, some rework before possible future inclusion)

The old offset server is down and sometimes causes exceptions like this:
​http://forum.openstreetmap.org/viewtopic.php?pid=323585#p323585

I also propose not to remove useOffsetServer and offsetServerUrl configuration from GUI but disable it permanently. When the new infrastructure will become mature, they could be re-enabled.

[Zverikk]

Since the inclusion of iodb plugin would require much more than just adding an offset server url configuration, I'm still for removing it for now completely. The setting, if you look closely, is stored deep into OffsetServer classes which are to go.

[akks]

Replying to Zverikk:

Since the inclusion of iodb plugin would require much more than just adding an offset server url configuration, I'm still for removing it for now completely. The setting, if you look closely, is stored deep into OffsetServer classes which are to go.

Storing settings should be of course removed. Modification of GUI is not principal but should be discussed (because it is about future strategy).

[Zverikk]

I doubt many users ever open settings panel of a TMS/WMS except of curiosity, so the importance of those few text fields and comboboxes is overrated, as well as its impact on a strategy (does josm even have one?).

[akks]

It was just an option. So we have 3 options:

1. Apply patch as is
2. Apply patch leavind disabled config field for future use
3. (bad one) Do not aply the patch
4. Apply the patch after tested.

@team: what is your opinion?

[stoecker]

If it is dead --> remove it. If parts reappear later, readd them later.

@Zverikk: Yes, josm has a strategy.

[akks]

In 5808/josm:

fix #8549, patch by Zverikk: Remove [deprecated] imagery offset server support

[akks]

OK, applied as is. Also checked that no plugins contain "OffsetServer" string in code.