Should focus on the proper column when double-clicking to edit a key/value

[naoliv]

When double-clicking on the Properties dialog on a key/value line (to edit something) we have this:
1) Double-click on the Key column value and the next dialog (where we can edit the values) is focused on key.
2) Double-click on the Value column and the next dialog also focus on key.

It should always focus on the field that I have double-clicked (If I double-clicked on "value" then it means that I want to edit the "value" and not the "key")

JOSM is:

Repository Root: ​http://josm.openstreetmap.de/svn
Build-Date: 2012-12-30 02:31:41
Last Changed Author: Don-vip
Revision: 5646
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: ​http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-12-29 16:07:47 +0100 (Sat, 29 Dec 2012)
Last Changed Rev: 5646

Identification: JOSM/1.5 (5646 en)
Memory Usage: 147 MB / 1756 MB (35 MB allocated, but free)
Java version: 1.7.0_09, Oracle Corporation, OpenJDK 64-Bit Server VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: Create_grid_of_ways (28412)
Plugin: PicLayer (28807)
Plugin: SimplifyArea (28807)
Plugin: buildings_tools (28891)
Plugin: editgpx (28807)
Plugin: geotools (29116)
Plugin: jts (28945)
Plugin: merge-overlap (28807)
Plugin: opendata (29115)
Plugin: pdfimport (28807)
Plugin: reverter (28820)
Plugin: turnrestrictions (28807)
Plugin: undelete (28807)
Plugin: utilsplugin2 (29124)

[simon04]

According to the code, values should always be selected. Might be a regression of r5642.

[Don-vip]

Here's a patch but don't know if it's the proper solution according to Simon's comment.

[simon04]

Ticket #8316 has been marked as a duplicate of this ticket.

[akks]

Happy New Year!

I'll try to check the patch and all this focus issues now.

[akks]

In 5656/josm:

Patch by Don-Vip fix #8311: Should focus on the proper column when double-clicking to edit a key/value +
see #8024: focus on Value after Alt-E, focus on Key after Shift-Enter, recent tag Click or Shift-Click

[akks]

@Don-vip, @simon04 : please check that the behaviour and code are correct now

@xeen and others on Linux systems: please check that middle-click buffer works correctly (code for manipulation from #5117 was moved)

Then the ticket can be closed :)

[xeen]

I played around a bit and couldn’t find any situation where the paste buffer is overwritten automatically. From the description of the bug, it looks like the original issue is fixed as well, or at least I couldn’t find any misbehaviour or problems.

[Don-vip]

Looks fine. Reopen this ticket if needed.