(too long) timeout at missing styles

[malenki]

Today JOSM got stuck at loading background settings using the most recent version down to r5516.
Due to JOSM outputting

Download redirected to 'http://maps.tilusnet.com/cgi-sys/suspendedpage.cgi'

I could hunt that behaviour down to this entry in the preferences.xml (which most probably was put there by the Mappaint-Styles-plugin):

    <map>
      <tag key='title' value='JOSM internal, no labels'/>
      <tag key='active' value='false'/>
      <tag key='ptoken' value='standard without labels'/>
      <tag key='url' value='http://maps.tilusnet.com/josmdata/elemstyles_nolabels.xml'/>
    </map>

After removing this lines JOSM started normally.
A test showed that after two minutes JOSM would start with the codeblock above not being removed.

I'd suggest to shorten the timeout of remote elements being used in JOSM if that is possible. There won't be many people waiting two minutes for JOSM to start...

[Don-vip]

In 5580/josm:

fix #8191 - Do not load external DTDs when reading (supposed) XML files. When reading W3C XHTML DTD (in case of invalid served XML file), this causes JOSM to hang two minutes.

[malenki]

Thanks for the quick fix!

[Don-vip]

You're welcome. Thanks for the investigation you have made, it was really helpful. If there were star banners for the best explained tickets, I would give you one :D