warn about missing power=tower/pole within powerlines

[skyper]

Please, have validator warn about nodes which are part of a power=line/minor_line and do not have a power=tower/pole tag.

Thanks

r5295

[Don-vip]

In 5300/josm:

fix #7812 - warn about missing power=tower/pole within powerlines

[skyper]

This was fast.

Thanks a lot :-)

[adjuva@…]

fix #7812 - warn about missing power=tower/pole within powerlines

The idea for this check is very good - too many mappers insert nodes to power lines by accident, when they edit landuses or ways.

But the current implementation creates too many false positives.

You should change the following details:

• no warnings should be generated for the start and end node of a way

• no warnings should be generated for nodes of ways with the tags power=line, line=busbar

• and if you can implement it: no warnings should be generated for nodes which are inside an area with the tags power=station|sub_station|generator

[Don-vip]

In 5312/josm:

fix #7812 - validator: power lines test improvements (no warning for start/end, node with power infrastructure tags, node inside power facilities)

[skyper]

Replying to adjuva:

You should change the following details:

• no warnings should be generated for the start and end node of a way

I often met powerlines which are parted due to different tags or simply because the line splits. I would rather say:

• do not warn at start/end node if no other way with tag power=line/minor_line is connected.

EDT: I tend to prefer some false possitives than to many misses as you can always ignore hits (with or without list) but it is much harder to find misses.

[Don-vip]

Replying to skyper:

Replying to adjuva:
I often met powerlines which are parted due to different tags or simply because the line splits. I would rather say:

• do not warn at start/end node if no other way with tag power=line/minor_line is connected.

Agreed. I could also completely remove the first/last node check now there is the "is in power facility" check. Is there a case where a power line can start/finish outside of a power station without a propoer power tag on its first/last node ?

[skyper]

Replying to Don-vip:

Replying to skyper:

Replying to adjuva:
I often met powerlines which are parted due to different tags or simply because the line splits. I would rather say:

• do not warn at start/end node if no other way with tag power=line/minor_line is connected.

Agreed. I could also completely remove the first/last node check now there is the "is in power facility" check. Is there a case where a power line can start/finish outside of a power station without a proper power tag on its first/last node ?

Do not any real cases, but maybe ask a bigger crowd at talk@ or tagging@.
The only case I know is that the line is not completely mapped so far, but then the warning is correct.

[Don-vip]

In 5359/josm:

fix #7812 - Validator: warn about missing power=tower/pole within powerlines, even for first and last node of the line.