Modify

Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#7640 closed defect (fixed)

[Patch] History query will not cancel or timeout

Reported by: AM909 Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc: AM909

Description

In r5181.

On about 1 out of 10 or 20 attempts to get the history of an object (Show button in History window), the progress dialog just sits there saying "Connecting...". It either times out never or perhaps after a very long (too long) time - I've waited minutes I'm sure.

Clicking the Cancel button has no effect either.

The only way to get JOSM usable again is to close the actual connection that is hanging (e.g. with tcpview).

The main API query also either does not time out, or waits far too long. About 1 in 20 queries there just hang, too. You know that, if it does not start receiving data after about 20 seconds, it's not going to do so ever. I believe the cancel does work here, though. It's just that it should abort and retry on its own because the download dialog does not "remember" the area you specified if you abort such a download, so you have to find/select the area again.

There may be other queries that block similarly.

BTW, does anyone know why these queries hang?

Attachments (1)

7640.patch (805 bytes ) - added by simon04 12 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 by simon04, 12 years ago

#5084 is related.

by simon04, 12 years ago

Attachment: 7640.patch added

comment:2 by simon04, 12 years ago

Summary: History query will not cancel or timeout[Patch] History query will not cancel or timeout

Attached patch should fix the problem. However, there are several (>10) more url.openConnection() in the code which may suffer from the same problem …

comment:3 by simon04, 12 years ago

Resolution: fixed
Status: newclosed

In 5324/josm:

fix #7640 - History query will not cancel or timeout

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.