Modify ↓

Opened 13 years ago

Closed 13 years ago

#7523 closed defect (fixed)

[PATCH] draw.target-highlight setting is not honoured completely

Reported by: Daeron Owned by: xeen
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

r5098 introduced a change in trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java lines 141 to 157, that add certain hilights without checking if higlighting is enabled (drawTargetHighlight). It results some objects to be highlighted a bit later when the view is eventually repainted.

Attached patch should fix this bug.

Attachments (1)

josm-fix-highlighting.patch​ (1.7 KB ) - added by Daeron 13 years ago.

Download all attachments as: .zip

Change History (3)

by Daeron, 13 years ago

Attachment: josm-fix-highlighting.patch​ added

comment:1 by xeen, 13 years ago

Thanks for catching this oversight. However, your patch will break the help text which shows if the next click is going to select a node or insert a new one. I’ll commit a slightly different one that should fix the problem as well.

comment:2 by xeen, 13 years ago

Resolution: → fixed
Status: new → closed

In 5104/josm:

fix #7523 (thanks Daeron)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain xeen.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.