Modify ↓

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#7164 closed defect (fixed)

[PATCH] followline fixes: don't loop forever, handle wraps correctly, stop at ambiguity

Reported by: ij Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: follow line Cc:

Description

I had some plans to extend followline but had to fix number of bugs/features in it first.

Attachments (4)

0001-Followline-didn-t-stop-when-the-way-became-closed.patch​ (1.0 KB ) - added by ij 13 years ago.
0001-Followline-didn-t-stop-when-the-way-became-closed.patch
0002-Make-followline-to-handle-wraps-and-stop-at-ambiguit.patch​ (6.2 KB ) - added by ij 13 years ago.
0002-Make-followline-to-handle-wraps-and-stop-at-ambiguit.patch
0001-Followline-didn-t-stop-when-the-way-became-closed.2.patch​ (1.2 KB ) - added by ij 13 years ago.
v2 1/2
0002-Make-followline-to-handle-wraps-and-stop-at-ambiguit.2.patch​ (7.5 KB ) - added by ij 13 years ago.
v2 2/2

Download all attachments as: .zip

Change History (9)

by ij, 13 years ago

Attachment: 0001-Followline-didn-t-stop-when-the-way-became-closed.patch​ added

0001-Followline-didn-t-stop-when-the-way-became-closed.patch

by ij, 13 years ago

Attachment: 0002-Make-followline-to-handle-wraps-and-stop-at-ambiguit.patch​ added

0002-Make-followline-to-handle-wraps-and-stop-at-ambiguit.patch

comment:1 by stoecker, 13 years ago

Owner: changed from team to ij
Status: new → needinfo

Please describe better what these changes do. I don't really understand your patch comment.

by ij, 13 years ago

Attachment: 0001-Followline-didn-t-stop-when-the-way-became-closed.2.patch​ added

v2 1/2

by ij, 13 years ago

Attachment: 0002-Make-followline-to-handle-wraps-and-stop-at-ambiguit.2.patch​ added

v2 2/2

in reply to:  1 comment:2 by ij, 13 years ago

Replying to stoecker:

Please describe better what these changes do. I don't really understand your patch comment.

Hopefully the v2 explains them more clearly. The second change is quite messy looking diff because of indentation changes due to moving code. Diff -b gives much shorter view (if you prefer, I could do that moving in a middle patch 2/3 but then the ambiguity problem is not solved in a single changeset but that gets split to two commits). In addition, the planned extending I was referring in the description of this ticket are _not_ part of these changes, this is just bugfix+ambiguity "feature" fix series (better to be explicit as I realized that it might confuse you to think that they were in the 2/2 change).

comment:3 by skyper, 13 years ago

Keywords: follow line added
Owner: changed from ij to team
Status: needinfo → new

Please, next time, change the owner back to team, after submitting information.

Thanks

comment:4 by stoecker, 13 years ago

Resolution: → fixed
Status: new → closed

In [4671/josm]:

fix #7164 - patch by ij - bugs fixes and improvements for FollowLine function

comment:5 by stoecker, 13 years ago

Regarding extensions - my father wishes a "follow areas when at a ambiguos position" :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.