Modify ↓

Opened 13 years ago

Closed 10 years ago

Last modified 9 years ago

#6994 closed enhancement (fixed)

Handle re-ordered nodes in history dialog for ways better

Reported by: olejorgenb Owned by: team
Priority: minor Milestone: 15.04
Component: Core Version:
Keywords: history, diff Cc:

Description (last modified by Don-vip)

See #6774

For basic cases it works well, but I still haven't fixed the case of changed order.

A particular bad case: ​http://www.openstreetmap.org/browse/way/36870578 (v1 vs v4) Almost all nodes are the same, but some funny stuff is going on with the order, making the diff odd. (part of the road is reversed and combined again?)

odd diff

A quick fix adding at least a different color for "re-ordered" nodes shouldn't be too hard. (although circular ways might need special handling)

Attachments (1)

2011-10-23-103719_796x495_scrot.png​ (31.1 KB ) - added by olejorgenb 13 years ago.
odd diff

Download all attachments as: .zip

Change History (5)

by olejorgenb, 13 years ago

Attachment: 2011-10-23-103719_796x495_scrot.png​ added

odd diff

comment:1 by Don-vip, 10 years ago

Description: modified (diff)

comment:2 by simon04, 10 years ago

Resolution: → fixed
Status: new → closed

In 8219/josm:

fix #6994 - History dialog: handle reversed ways better

This is achieved by comparing the reference elements in reversed order and
testing whether this diff requires less deletions+inserts

comment:3 by simon04, 10 years ago

Milestone: → 15.04

comment:4 by rickmastfan67, 9 years ago

This introduced a regression. See #12016.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.