shortcut for add node changed

[dieterdreist]

Somehow the default shortcut for add node was recently changed from "a" to "d". The delete shortcut changed from "d" to shift+alt+d and "a" now is Tool:all inside.

Please revert this, it does not make sense and is an important usability issue for all previous users.

Maybe this is a plugin issue?

[rickmastfan67]

What plugins do you have installed? I'm running r4419 and the problem doesn't happen.

[dieterdreist]

Replying to rickmastfan67:

Plugin: ImportImagePlugin (26606)
Plugin: OpeningHoursEditor (26606)
Plugin: PicLayer (26606)
Plugin: alignways (26606)
Plugin: buildings_tools (26606)
Plugin: dataimport (26606)
Plugin: osmarender (26606)
Plugin: pdfimport (26606)
Plugin: photo_geotagging (26606)
Plugin: proj4j (26606)
Plugin: public_transport (26606)
Plugin: restart (26606)
Plugin: reverter (26606)
Plugin: tagging-preset-tester (26606)
Plugin: undelete (26606)
Plugin: utilsplugin2 (26641)
Plugin: waypoint_search (26606)

[skyper]

Please try it with a new/empty josm directory.

This seems to be a problem with a plugin. Please try to figure out which one(s).

Some more infomation like operating system, java version and josm version would also be helpful.

Thanks

[dieterdreist]

It now became worse ;-). I don't see any "mode"-shortcuts in the preferences menu any more (some of them still do work). IMHO there could also be a box: use all defaults (as it is currently you have to check all entries manually if I see it right).

[dieterdreist]

After restarting, the modes came back to the shortcut preferences. All shortcuts are set to default. IMHO a plugin should not be able to change a core shortcut (maybe except user confirms explicitly, but then the shortcut is not "default" any more). I am still investigating, which plugin creates the problem. The current silent shortcut conflicts are:

Silent shortcut conflict: 'menu:PicLayer' moved by 'menu:Imagery' to 'Alt+B'.
Silent shortcut conflict: 'tools:taggingresettester' moved by 'tools:multipoly' to 'Alt+Umschalt+A'.
Silent shortcut conflict: 'menu:Public Transport' moved by 'menu:Presets' to 'Alt+C'.
Silent shortcut conflict: 'tools:intway' moved by 'tools:alignways' to 'Alt+Umschalt+I'.
Silent shortcut conflict: 'tools:selinside' moved by 'tools:intway' to 'A'.
Silent shortcut conflict: 'mapmode:draw' moved by 'tools:selinside' to 'D'.
Silent shortcut conflict: 'mapmode:delete' moved by 'mapmode:draw' to 'Alt+Umschalt+D'.
Silent shortcut conflict: 'mapmode:parallel' moved by 'tools:pdfimport' to 'Alt+Umschalt+P'.
Silent shortcut conflict: 'subwindow:properties' moved by 'mapmode:parallel' to 'Alt+D'.
Silent shortcut conflict: 'properties:add' moved by 'menu:PicLayer' to 'Alt+G'.
Silent shortcut conflict: 'subwindow:authors' moved by 'tools:taggingresettester' to 'Alt+J'.
Keystroke alt pressed J is already assigned to utilsplugin2.ExtractPointAction@e634bf, will be overridden by org.openstreetmap.josm.gui.dialogs.ToggleDialog$ToggleDialogAction@bd4dc2
Silent shortcut conflict: 'subwindow:conflict' moved by 'menu:Public Transport' to 'Alt+Umschalt+C'.

and there is also some Toolbar actions without name (not sure if they belong to this thread):

Registered toolbar action without name: org.openstreetmap.josm.plugins.osmarender.OsmarenderPlugin$Action
Toolbar action without name: org.openstreetmap.josm.plugins.ImportImagePlugin.LoadImageAction
Toolbar action without name: org.openstreetmap.josm.plugins.osmarender.OsmarenderPlugin$Action
Toolbar action without name: org.openstreetmap.josm.plugins.piclayer.NewLayerFromFileAction
Toolbar action without name: org.openstreetmap.josm.plugins.piclayer.NewLayerFromClipboardAction

[dieterdreist]

It is the utilsplugin2. Happy to have found this, JOSM was unusuable with this bug. After I deactivated the plugin everything turned back normal. Btw.: would it be possible to have error and warning messages like the ones above somehow easily correlateable (the same) with the plugin name? In this case the plugin is called utilsplugin2 and the errors are about "tool".

[skyper]

Can not reproduce with only utilsplugin2 installed with new preference directory.

Using /usr/lib/jvm/java-6-openjdk/bin/java to execute josm.
Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-09-14 01:32:24
Last Changed Author: stoecker
Revision: 4419
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-09-13 12:16:47 +0200 (Tue, 13 Sep 2011)
Last Changed Rev: 4419

GET http://api.openstreetmap.org/api/capabilities... OK
Communications with http://api.openstreetmap.org/api established using protocol version 0.6.
loading plugin 'utilsplugin2' (version 26646)

There is either at least one more plugin involved or your settings are outdated.
JOSM should not change core shortcuts thought but this is already requested in #6341.

[rickmastfan67]

Silent shortcut conflict: 'tools:selinside' moved by 'tools:intway' to 'A'.

The conflict with "A" is caused by "alignways" v26606. Thus, I've updated the component to reflect that.

[akks]

I have just moved AlignWays to Ctrl-Alt-A to eliminate conflicts with Utilsplugin2 and chain reaction described above.

I key is used with almost all modifiers for Info (core) and Intersection/Inside actions (Utilsplugin2).

If something is wrong, your can change shortcuts some other ways, if all works as desired - close this bug please :)

[dieterdreist]

I reactivated the utilsplugin2 and the problem with "a" remapped returned:

loading plugin 'utilsplugin2' (version 26696)
Silent shortcut conflict: 'tools:intway' moved by 'tools:alignways' to 'Alt+Umschalt+I'.
Silent shortcut conflict: 'tools:selinside' moved by 'tools:intway' to 'A'.

[rickmastfan67]

Has your "alignways" plugin been updated to [o26692]?

Because I have the latest of all the plugins mentioned in comment:#3 and "a" problem is NOT happening.

[dieterdreist]

Replying to rickmastfan67:

Has your "alignways" plugin been updated to [o26692]?

Because I have the latest of all the plugins mentioned in comment:#3 and "a" problem is NOT happening.

No, the "alignways" plugin was in version 26606 (and JOSM reported in the plugins tab that this was the newest version available). I manually hit the button "update plugins" (never had to do this in the past, JOSM always updated automatically) and got the newest version. When was the plugin update mechanism changed? I think that it would be nice to notify about important changes like this.

[dieterdreist]

Now it works for me (updated plugin manually).

[rickmastfan67]

Replying to dieterdreist:

Now it works for me (updated plugin manually).

If the "a" problem is now gone, you should mark this as fixed. ;)

[dieterdreist]

Replying to rickmastfan67:

Replying to dieterdreist:

Now it works for me (updated plugin manually).

If the "a" problem is now gone, you should mark this as fixed. ;)

Set it to fixed. Actually the reason for not doing this immediately was that I was not sure, whether the issue was solved because someone updated the plugin code (=fixed) or because I manually updated the plugin on my system (=worksforme, potentially a problem with the JOSM plugin update mechanism).