Modify

Opened 13 years ago

Closed 13 years ago

#6540 closed enhancement (fixed)

Enhancement [patch] New gps-trace coloring method: direction

Reported by: anonymous Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: gps-trace color direction Cc:

Description

This patch adds a fourth gps-trace coloring mode which is very useful. Additional to "constant color", "velocity" and "dilution of precision" the option "direction" is created.
Coloring the traces according to the direction of each segment especially helps to assign traces to each side of a street separately.

Attachments (4)

gpx_color_direction.patch (5.4 KB ) - added by anonymous 13 years ago.
josm sourcecode patch created with "git dff"
highway_junction.png (14.2 KB ) - added by anonymous 13 years ago.
illustration what the new method looks like
gpx_color_direction.2.patch (5.1 KB ) - added by anonymous 13 years ago.
updated version. leaves internal integers for existing modes unchanged.
gpx_color_direction.2--color-mod.patch (6.4 KB ) - added by bastiK 13 years ago.

Download all attachments as: .zip

Change History (9)

by anonymous, 13 years ago

Attachment: gpx_color_direction.patch added

josm sourcecode patch created with "git dff"

by anonymous, 13 years ago

Attachment: highway_junction.png added

illustration what the new method looks like

comment:1 by anonymous, 13 years ago

Summary: new gps-trace coloring method: directionEnhancement [patch] New gps-trace coloring method: direction

by anonymous, 13 years ago

Attachment: gpx_color_direction.2.patch added

updated version. leaves internal integers for existing modes unchanged.

comment:2 by bastiK, 13 years ago

This is pretty cool, actually. I adjusted the colors a little, see attached patch.

in reply to:  2 ; comment:3 by anonymous, 13 years ago

Replying to bastiK:

This is pretty cool, actually. I adjusted the colors a little, see attached patch.

The adjusted colors look nice. Actually I thought about changing the hsv colors myself a bit, but then I rather kept it simple. However I think the x*x*x transition function is a bit strong, what about using x*x or x1.5 ?

Make sure to adjust line 47 in DrawingPreference.java !

in reply to:  3 comment:4 by bastiK, 13 years ago

Replying to anonymous:

Replying to bastiK:

This is pretty cool, actually. I adjusted the colors a little, see attached patch.

The adjusted colors look nice. Actually I thought about changing the hsv colors myself a bit, but then I rather kept it simple. However I think the x*x*x transition function is a bit strong, what about using x*x or x1.5 ?

The problem is that yellow is dominated by green and red. The strong transition is an easy way to ensure, that all 4 colors appear in a balanced way.

comment:5 by bastiK, 13 years ago

Resolution: fixed
Status: newclosed

In [4207/josm]:

applied #6540 (anonymous contribution) - New gps-trace coloring method: direction

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.