Better handling of exceptions thrown while drawing.

[anonymous]

Tried to fetch landsat imagery and ended up with this:

The landsat WMS url is in my configuration:
​http://onearth.jpl.nasa.gov/wms.cgi?request=GetMap&layers=global_mosaic&styles=&srs=EPSG:4326&format=image/jpeg

Path: josm
URL: ​http://www.openstreetmap.de/svn/josm
Repository Root: ​http://www.openstreetmap.de/svn/josm
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Revision: 546
Node Kind: directory
Last Changed Rev: 546
Last Changed Date: 2008-02-17 01:04:10 +0100 (Sun, 17 Feb 2008)

java.lang.NullPointerException

at wmsplugin.GeorefImage.paint(GeorefImage.java:43)
at wmsplugin.WMSLayer.paint(WMSLayer.java:83)
at org.openstreetmap.josm.gui.MapView.paint(MapView.java:197)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at javax.swing.JLayeredPane.paint(Unknown Source)
at javax.swing.JComponent.paintChildren(Unknown Source)
at javax.swing.JComponent.paintToOffscreen(Unknown Source)
at javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(Unknown Source)
at javax.swing.RepaintManager$PaintManager.paint(Unknown Source)
at javax.swing.BufferStrategyPaintManager.paint(Unknown Source)
at javax.swing.RepaintManager.paint(Unknown Source)
at javax.swing.JComponent.paint(Unknown Source)
at java.awt.GraphicsCallback$PaintCallback.run(Unknown Source)
at sun.awt.SunGraphicsCallback.runOneComponent(Unknown Source)
at sun.awt.SunGraphicsCallback.runComponents(Unknown Source)
at java.awt.Container.paint(Unknown Source)
at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
at javax.swing.RepaintManager.seqPaintDirtyRegions(Unknown Source)
at javax.swing.SystemEventQueueUtilities$ComponentWorkRequest.run(Unknown Source)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Also, when I got to this, the window "Should the plugin be disabled" will merely oscillate between "Unexpected exception" and the "Should the plugin be disabled" when "Do nothing" and "No" is pressed. Report bug will simply give the stacktrace above and "Yes" is not the button to use (I do not want to disable the plugin permanently in configuration, perhaps only try to unload it in memory) - though using YEs will bring further messages "plugin was disabled in configuration" followed by "plugin can not be unloaded" and bringing back the loop.

At end, I have to terminate JVM process to exit JOSM. No chance to click out of this dialog madness.

I guess "Should the plugin be disabled" window should have extra two buttons "Only unload" and "Exit JOSM", the "Unexpected exception" should have "Exit JOSM" too.

[Gabriel Ebner <ge@…>]

The WMS plugin no longer fails in this case since r6984.